From 720e896e17929ffdba9720baf86f952a6a21179b Mon Sep 17 00:00:00 2001 From: Robin Ward Date: Thu, 31 Jan 2019 14:47:41 -0500 Subject: [PATCH] FIX: `PostActionCreator` was not checking the guardian properly It also exposed a bug in the EmailReceiver spec, where a test had a user liking their own post and was not failing. --- lib/post_action_creator.rb | 2 +- spec/components/email/receiver_spec.rb | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/post_action_creator.rb b/lib/post_action_creator.rb index 32e4b2aa13a..21b951a638a 100644 --- a/lib/post_action_creator.rb +++ b/lib/post_action_creator.rb @@ -7,7 +7,7 @@ class PostActionCreator end def perform(action) - guardian.ensure_post_can_act!(@post, action, opts: { + guardian.ensure_post_can_act!(@post, PostActionType.types[action], opts: { taken_actions: PostAction.counts_for([@post].compact, @user)[@post&.id] }) diff --git a/spec/components/email/receiver_spec.rb b/spec/components/email/receiver_spec.rb index 75ac46d6db1..f243065e490 100644 --- a/spec/components/email/receiver_spec.rb +++ b/spec/components/email/receiver_spec.rb @@ -241,7 +241,7 @@ describe Email::Receiver do let(:category) { Fabricate(:category) } let(:user) { Fabricate(:user, email: "discourse@bar.com") } let(:topic) { create_topic(category: category, user: user) } - let(:post) { create_post(topic: topic, user: user) } + let(:post) { create_post(topic: topic) } let!(:post_reply_key) do Fabricate(:post_reply_key,