github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-05-28 01:56:58 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

DEV: Do not trigger floatkit 'hover' for touch events (#30793)

Browse Source 
When tapping something on a touch-enabled device, `mouseMove` events are
still fired, so floatkit would still be triggered even if configured for
'hover' only. For links, this would be particularly strange, because the
tooltip would appear for a split-second, before the page navigation
occured.

To avoid this problem, we can use the more-modern 'pointerMove' event,
and check the `pointerType` to exclude 'touch'
This commit is contained in:
David Taylor
2025-01-16 12:36:47 +00:00
committed by GitHub
parent f28eb5b0dc
commit 72f4588d3b
9 changed files with 29 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
plugins/chat/test/javascripts/components/chat-channel-test.js
View File

@ -159,7 +159,7 @@ module(
test("it shows status tooltip", async function (assert) {
await render(hbs`<ChatChannel @channel={{this.channel}} /><DTooltips />`);
await triggerEvent(statusSelector(mentionedUser.username), "mousemove");
await triggerEvent(statusSelector(mentionedUser.username), "pointermove");
assert
.dom(".user-status-tooltip-description")