github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-05-22 05:31:14 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

DEV: Use cloneJSON instead of spread operator (#16615)

Browse Source 
Spread does shallow clone, so changes in these tests leak.
This commit is contained in:
Jarek Radosz
2022-05-04 08:11:45 +02:00
committed by GitHub
parent 79c854d9be
commit 73940fa968
1 changed files with 4 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
plugins/discourse-local-dates/test/javascripts/acceptance/download-calendar-test.js
View File

@ -8,6 +8,7 @@ import I18n from "I18n";
import { test } from "qunit"; import { test } from "qunit";
import { fixturesByUrl } from "discourse/tests/helpers/create-pretender"; import { fixturesByUrl } from "discourse/tests/helpers/create-pretender";
import sinon from "sinon"; import sinon from "sinon";
import { cloneJSON } from "discourse-common/lib/object";
acceptance( acceptance(
"Local Dates - Download calendar without default calendar option set", "Local Dates - Download calendar without default calendar option set",
@ -15,7 +16,7 @@ acceptance(
needs.user({ default_calendar: "none_selected" }); needs.user({ default_calendar: "none_selected" });
needs.settings({ discourse_local_dates_enabled: true }); needs.settings({ discourse_local_dates_enabled: true });
needs.pretender((server, helper) => { needs.pretender((server, helper) => {
const response = { ...fixturesByUrl["/t/281.json"] }; const response = cloneJSON(fixturesByUrl["/t/281.json"]);
const startDate = moment const startDate = moment
.tz("Africa/Cairo") .tz("Africa/Cairo")
.add(1, "days") .add(1, "days")
@ -45,7 +46,7 @@ acceptance(
needs.user({ default_calendar: "none_selected" }); needs.user({ default_calendar: "none_selected" });
needs.settings({ discourse_local_dates_enabled: true }); needs.settings({ discourse_local_dates_enabled: true });
needs.pretender((server, helper) => { needs.pretender((server, helper) => {
const response = { ...fixturesByUrl["/t/281.json"] }; const response = cloneJSON(fixturesByUrl["/t/281.json"]);
const startDate = moment const startDate = moment
.tz("Africa/Cairo") .tz("Africa/Cairo")
.subtract(1, "days") .subtract(1, "days")
@ -71,7 +72,7 @@ acceptance(
needs.user({ default_calendar: "google" }); needs.user({ default_calendar: "google" });
needs.settings({ discourse_local_dates_enabled: true }); needs.settings({ discourse_local_dates_enabled: true });
needs.pretender((server, helper) => { needs.pretender((server, helper) => {
const response = { ...fixturesByUrl["/t/281.json"] }; const response = cloneJSON(fixturesByUrl["/t/281.json"]);
const startDate = moment const startDate = moment
.tz("Africa/Cairo") .tz("Africa/Cairo")
.add(1, "days") .add(1, "days")