FIX: 1868 Security: Dangerous Send

spec/components/site_setting_extension_spec.rb

@@ -58,6 +58,11 @@ describe SiteSettingExtension do
         settings.refresh!
         settings.test_setting.should_not == 77
       end
+
+      it "can be overridden with set" do
+        settings.set("test_setting", 12)
+        settings.test_setting.should == 12
+      end
     end
   end
 
@@ -89,6 +94,11 @@ describe SiteSettingExtension do
         settings.test_str = 100
         settings.test_str.should.eql? "100"
       end
+
+      it "can be overridden with set" do
+        settings.set("test_str", "hi")
+        settings.test_str.should == "hi"
+      end
     end
   end
 
@@ -128,6 +138,11 @@ describe SiteSettingExtension do
         settings.refresh!
         settings.test_hello?.should_not == false
       end
+
+      it "can be overridden with set" do
+        settings.set("test_hello", true)
+        settings.test_hello?.should == true
+      end
     end
   end
 
@@ -189,4 +204,14 @@ describe SiteSettingExtension do
     end
   end
 
+  describe "set for an invalid setting name" do
+    it "raises an error" do
+      settings.setting(:test_setting, 77)
+      settings.refresh!
+      expect {
+        settings.set("provider", "haxxed")
+      }.to raise_error(ArgumentError)
+    end
+  end
+
 end