github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-05-22 22:43:33 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

PERF: stop downloading images from post processor and lean on uploads

Browse Source 
Previously we would unconditionally fetch all images via HTTP to grab
original sizing from cooked post processor in 2 different spots.

This was wasteful as we already calculate and cache this info in upload records.

This also simplifies some specs and reduces use of mocks.
This commit is contained in:
Sam
2022-11-25 12:40:31 +11:00
committed by GitHub
parent 45f3e9f19e
commit 755ca0fcbb
6 changed files with 39 additions and 27 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
lib/cooked_processor_mixin.rb
View File

@ -45,10 +45,7 @@ module CookedProcessorMixin
oneboxed_images.each do |img|
next if img["src"].blank?
src = img["src"].sub(/^https?:/i, "")
parent = img.parent
img_classes = (img["class"] || "").split(" ")
link_classes = ((parent&.name == "a" && parent["class"]) || "").split(" ")
if respond_to?(:process_hotlinked_image, true)
still_an_image = process_hotlinked_image(img)
@ -183,7 +180,13 @@ module CookedProcessorMixin
return unless is_valid_image_url?(absolute_url)
@size_cache[url] = FastImage.size(absolute_url)
upload = Upload.get_from_url(absolute_url)
if upload && upload.width && upload.width > 0
@size_cache[url] = [upload.width, upload.height]
else
@size_cache[url] = FastImage.size(absolute_url)
end
rescue Zlib::BufError, URI::Error, OpenSSL::SSL::SSLError
# FastImage.size raises BufError for some gifs, leave it.
end