github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-06-03 19:39:30 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

FIX: min/max username length limits weren't validated (#17382)

Browse Source 
* FIX: min/max username length limits weren't validated

The custom validators introduced in e0d7cda made so we ignored the mix
and max values set on site_settings.yml. That change allowed admins to
set values outside of the range defined on the yaml file.

Related to https://meta.discourse.org/t/group-names-with-more-than-60-characters-broken/232115?u=falco

Co-authored-by: Alan Guo Xiang Tan <gxtan1990@gmail.com>
This commit is contained in:
Rafael dos Santos Silva
2022-07-08 12:00:47 -03:00
committed by GitHub
parent 4c1b8e736d
commit 75e40baa64
6 changed files with 61 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
lib/site_settings/yaml_loader.rb
View File

@ -19,6 +19,10 @@ class SiteSettings::YamlLoader
raise StandardError, "The site setting `#{setting_name}` in '#{@file}' is missing default value."
end
if hash.values_at('min', 'max').any? && hash['validator'].present?
raise StandardError, "The site setting `#{setting_name}` in '#{@file}' will have it's min/max validation ignored because there is a validator also specified."
end
yield category, setting_name, value, hash.deep_symbolize_keys!
else
# Simplest case. site_setting_name: 'default value'