github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-05-29 01:31:35 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

Fix all the errors to get our tests green on Rails 5.1.

Browse Source
This commit is contained in:
Guo Xiang Tan
2017-08-31 12:06:56 +08:00
parent 898ee93547
commit 77d4c4d8dc
989 changed files with 5114 additions and 3117 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
spec/controllers/admin/reports_controller_spec.rb
View File

@ -16,11 +16,11 @@ describe Admin::ReportsController do
it "never calls Report.find" do
Report.expects(:find).never
xhr :get, :show, type: invalid_id
get :show, params: { type: invalid_id }, format: :json
end
it "returns 404" do
xhr :get, :show, type: invalid_id
get :show, params: { type: invalid_id }, format: :json
expect(response.status).to eq(404)
end
end
@ -30,7 +30,7 @@ describe Admin::ReportsController do
context 'missing report' do
before do
Report.expects(:find).with('active', instance_of(Hash)).returns(nil)
xhr :get, :show, type: 'active'
get :show, params: { type: 'active' }, format: :json
end
it "renders the report as JSON" do
@ -41,7 +41,7 @@ describe Admin::ReportsController do
context 'a report is found' do
before do
Report.expects(:find).with('active', instance_of(Hash)).returns(Report.new('active'))
xhr :get, :show, type: 'active'
get :show, params: { type: 'active' }, format: :json
end
it "renders the report as JSON" do
@ -65,7 +65,7 @@ describe Admin::ReportsController do
topic
other_topic
xhr :get, :show, type: 'topics', category_id: category.id
get :show, params: { type: 'topics', category_id: category.id }, format: :json
expect(response).to be_success
@ -85,7 +85,7 @@ describe Admin::ReportsController do
other_user
group.add(user)
xhr :get, :show, type: 'signups', group_id: group.id
get :show, params: { type: 'signups', group_id: group.id }, format: :json
expect(response).to be_success