Fix all the errors to get our tests green on Rails 5.1.

This commit is contained in:
Guo Xiang Tan
2017-08-31 12:06:56 +08:00
parent 898ee93547
commit 77d4c4d8dc
989 changed files with 5114 additions and 3117 deletions

View File

@ -11,7 +11,7 @@ describe StylesheetsController do
digest = StylesheetCache.first.digest
StylesheetCache.destroy_all
get :show, name: "desktop_rtl_#{digest}"
get :show, params: { name: "desktop_rtl_#{digest}" }, format: :json
expect(response).to be_success
cached = StylesheetCache.first
@ -21,7 +21,7 @@ describe StylesheetsController do
# tmp folder destruction and cached
`rm #{Stylesheet::Manager.cache_fullpath}/*`
get :show, name: "desktop_rtl_#{digest}"
get :show, params: { name: "desktop_rtl_#{digest}" }, format: :json
expect(response).to be_success
# there is an edge case which is ... disk and db cache is nuked, very unlikely to happen
@ -37,10 +37,16 @@ describe StylesheetsController do
`rm #{Stylesheet::Manager.cache_fullpath}/*`
get :show, name: builder.stylesheet_filename.sub(".css", "")
get :show, params: {
name: builder.stylesheet_filename.sub(".css", "")
}, format: :json
expect(response).to be_success
get :show, name: builder.stylesheet_filename_no_digest.sub(".css", "")
get :show, params: {
name: builder.stylesheet_filename_no_digest.sub(".css", "")
}, format: :json
expect(response).to be_success
builder = Stylesheet::Manager.new(:desktop_theme, theme.key)
@ -48,10 +54,16 @@ describe StylesheetsController do
`rm #{Stylesheet::Manager.cache_fullpath}/*`
get :show, name: builder.stylesheet_filename.sub(".css", "")
get :show, params: {
name: builder.stylesheet_filename.sub(".css", "")
}, format: :json
expect(response).to be_success
get :show, name: builder.stylesheet_filename_no_digest.sub(".css", "")
get :show, params: {
name: builder.stylesheet_filename_no_digest.sub(".css", "")
}, format: :json
expect(response).to be_success
end