From 7803a06e50844c2dbb4018e7920ab6e93855a34d Mon Sep 17 00:00:00 2001 From: Ming HU Date: Mon, 24 Oct 2016 10:32:21 +0800 Subject: [PATCH] Use expect change for groups_controller_spec.rb --- spec/controllers/groups_controller_spec.rb | 28 ++++++++++++---------- 1 file changed, 16 insertions(+), 12 deletions(-) diff --git a/spec/controllers/groups_controller_spec.rb b/spec/controllers/groups_controller_spec.rb index c770d8408d5..b926e4d6c62 100644 --- a/spec/controllers/groups_controller_spec.rb +++ b/spec/controllers/groups_controller_spec.rb @@ -200,19 +200,22 @@ describe GroupsController do end it "removes by id" do - xhr :delete, :remove_member, id: group.id, user_id: user.id + expect do + xhr :delete, :remove_member, id: group.id, user_id: user.id - expect(response).to be_success - group.reload - expect(group.users.count).to eq(0) + expect(response).to be_success + group.reload + end.to change{group.users.count}.from(1).to(0) end it "removes by username" do - xhr :delete, :remove_member, id: group.id, username: user.username + expect do + xhr :delete, :remove_member, id: group.id, username: user.username - expect(response).to be_success - group.reload - expect(group.users.count).to eq(0) + expect(response).to be_success + group.reload + + end.to change{group.users.count}.from(1).to(0) end it "removes user.primary_group_id when user is removed from group" do @@ -226,10 +229,11 @@ describe GroupsController do end it "removes by user_email" do - xhr :delete, :remove_member, id: group.id, user_email: user.email - expect(response).to be_success - group.reload - expect(group.users.count).to eq(0) + expect do + xhr :delete, :remove_member, id: group.id, user_email: user.email + expect(response).to be_success + group.reload + end.to change{group.users.count}.from(1).to(0) end end