github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-05-24 03:36:18 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

DEV: Fix another report flaky (#28868)

Browse Source 
Followup 0323b366f3023843468d1024135bbb1c7c6f0483

This was happening because another spec was adding a
report using the plugin API, but there was nothing
resetting that, so later in the reports controller
when we did Report.singleton_methods, we ended up
with another report with no translation, causing another
error.
This commit is contained in:
Martin Brennan
2024-09-12 10:34:38 +10:00
committed by GitHub
parent bca82e9dec
commit 78268ca767
2 changed files with 7 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
app/models/report.rb
View File

@ -224,6 +224,11 @@ class Report
singleton_class.instance_eval { define_method("report_#{name}", &block) } singleton_class.instance_eval { define_method("report_#{name}", &block) }
end end
# Only used for testing.
def Report.remove_report(name)
singleton_class.instance_eval { remove_method("report_#{name}") }
end
def self._get(type, opts = nil) def self._get(type, opts = nil)
opts ||= {} opts ||= {}

2
spec/lib/plugin/instance_spec.rb
View File

@ -358,6 +358,8 @@ TEXT
end end
describe "#add_report" do describe "#add_report" do
after { Report.remove_report("readers") }
it "adds a report" do it "adds a report" do
plugin = Plugin::Instance.new nil, "/tmp/test.rb" plugin = Plugin::Instance.new nil, "/tmp/test.rb"
plugin.add_report("readers") {} plugin.add_report("readers") {}