github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-06-01 17:40:43 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

REFACTOR: Remove Discourse.Category constants

Browse Source
This commit is contained in:
Robin Ward
2019-11-08 13:30:41 -05:00
parent e51efce356
commit 7ac2a55588
28 changed files with 95 additions and 78 deletions
Download Patch File Download Diff File Expand all files Collapse all files

39
test/javascripts/models/category-test.js.es6
View File

@ -7,7 +7,7 @@ QUnit.test("slugFor", assert => {
const store = createStore();
const slugFor = function(cat, val, text) {
assert.equal(Discourse.Category.slugFor(cat), val, text);
assert.equal(Category.slugFor(cat), val, text);
};
slugFor(
@ -86,35 +86,35 @@ QUnit.test("findBySlug", assert => {
}),
categoryList = [darth, luke, hurricane, newsFeed, time, bah];
sandbox.stub(Discourse.Category, "list").returns(categoryList);
sandbox.stub(Category, "list").returns(categoryList);
assert.deepEqual(
Discourse.Category.findBySlug("darth"),
Category.findBySlug("darth"),
darth,
"we can find a category"
);
assert.deepEqual(
Discourse.Category.findBySlug("luke", "darth"),
Category.findBySlug("luke", "darth"),
luke,
"we can find the other category with parent category"
);
assert.deepEqual(
Discourse.Category.findBySlug("熱帶風暴畫眉"),
Category.findBySlug("熱帶風暴畫眉"),
hurricane,
"we can find a category with CJK slug"
);
assert.deepEqual(
Discourse.Category.findBySlug("뉴스피드", "熱帶風暴畫眉"),
Category.findBySlug("뉴스피드", "熱帶風暴畫眉"),
newsFeed,
"we can find a category with CJK slug whose parent slug is also CJK"
);
assert.deepEqual(
Discourse.Category.findBySlug("时间", "darth"),
Category.findBySlug("时间", "darth"),
time,
"we can find a category with CJK slug whose parent slug is english"
);
assert.deepEqual(
Discourse.Category.findBySlug("bah", "熱帶風暴畫眉"),
Category.findBySlug("bah", "熱帶風暴畫眉"),
bah,
"we can find a category with english slug whose parent slug is CJK"
);
@ -150,35 +150,35 @@ QUnit.test("findSingleBySlug", assert => {
}),
categoryList = [darth, luke, hurricane, newsFeed, time, bah];
sandbox.stub(Discourse.Category, "list").returns(categoryList);
sandbox.stub(Category, "list").returns(categoryList);
assert.deepEqual(
Discourse.Category.findSingleBySlug("darth"),
Category.findSingleBySlug("darth"),
darth,
"we can find a category"
);
assert.deepEqual(
Discourse.Category.findSingleBySlug("darth/luke"),
Category.findSingleBySlug("darth/luke"),
luke,
"we can find the other category with parent category"
);
assert.deepEqual(
Discourse.Category.findSingleBySlug("熱帶風暴畫眉"),
Category.findSingleBySlug("熱帶風暴畫眉"),
hurricane,
"we can find a category with CJK slug"
);
assert.deepEqual(
Discourse.Category.findSingleBySlug("熱帶風暴畫眉/뉴스피드"),
Category.findSingleBySlug("熱帶風暴畫眉/뉴스피드"),
newsFeed,
"we can find a category with CJK slug whose parent slug is also CJK"
);
assert.deepEqual(
Discourse.Category.findSingleBySlug("darth/时间"),
Category.findSingleBySlug("darth/时间"),
time,
"we can find a category with CJK slug whose parent slug is english"
);
assert.deepEqual(
Discourse.Category.findSingleBySlug("熱帶風暴畫眉/bah"),
Category.findSingleBySlug("熱帶風暴畫眉/bah"),
bah,
"we can find a category with english slug whose parent slug is CJK"
);
@ -191,13 +191,10 @@ QUnit.test("findByIds", assert => {
2: store.createRecord("category", { id: 2 })
};
sandbox.stub(Discourse.Category, "idMap").returns(categories);
assert.deepEqual(
Discourse.Category.findByIds([1, 2, 3]),
_.values(categories)
);
sandbox.stub(Category, "idMap").returns(categories);
assert.deepEqual(Category.findByIds([1, 2, 3]), _.values(categories));
assert.deepEqual(Discourse.Category.findByIds(), []);
assert.deepEqual(Category.findByIds(), []);
});
QUnit.test("search with category name", assert => {