github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-06-03 19:39:30 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

UX: Move editing group from into an individual tab.

Browse Source
This commit is contained in:
Guo Xiang Tan
2016-12-13 15:15:20 +08:00
parent 5a5aea72b5
commit 7bfabb029b
23 changed files with 242 additions and 180 deletions
Download Patch File Download Diff File Expand all files Collapse all files

33
test/javascripts/acceptance/group-edit-test.js.es6 Normal file
View File

@ -0,0 +1,33 @@
import { acceptance } from "helpers/qunit-helpers";
acceptance("Editing Group", {
loggedIn: true
});
test("Editing group", () => {
visit("/groups/discourse/edit");
andThen(() => {
ok(find('.group-flair-inputs').length === 1, 'it should display avatar flair inputs');
ok(find('.group-edit-bio').length === 1, 'it should display group bio input');
ok(find('.group-edit-title').length === 1, 'it should display group title input');
ok(find('.group-edit-public').length === 1, 'it should display group public input');
ok(find('.group-edit-allow-membership-requests').length === 1, 'it should display group allow_membership_requets input');
ok(find('.group-members-input .item').length === 7, 'it should display group members');
ok(find('.group-members-input-selector').length === 1, 'it should display input to add group members');
ok(find('.group-members-input-selector .add[disabled]').length === 1, 'add members button should be disabled');
});
click('.group-edit-public');
andThen(() => {
ok(find('.group-edit-allow-membership-requests[disabled]').length === 1, 'it should disable group allow_membership_requets input');
});
click('.group-edit-public');
click('.group-edit-allow-membership-requests');
andThen(() => {
ok(find('.group-edit-public[disabled]').length === 1, 'it should disable group public input');
});
});

0
test/javascripts/acceptance/groups-logs-test.js.es6 → test/javascripts/acceptance/group-logs-test.js.es6
View File

29
test/javascripts/acceptance/groups-test.js.es6
View File

@ -27,8 +27,9 @@ test("Browsing Groups", () => {
visit("/groups/discourse/messages");
andThen(() => {
ok(find(".nav-stacked li a[title='Messages']").length === 0, 'it should not show messages tab if user is admin');
ok(find(".nav-stacked li a[title='Logs']").length === 0, 'it should not show Logs tab if user is admin');
ok(find(".nav-stacked li a[title='Messages']").length === 0, 'it should not show messages tab if user is not admin');
ok(find(".nav-stacked li a[title='Edit Group']").length === 0, 'it should not show messages tab if user is not admin');
ok(find(".nav-stacked li a[title='Logs']").length === 0, 'it should not show Logs tab if user is not admin');
ok(count('.user-stream .item') > 0, "it lists stream items");
});
});
@ -41,31 +42,9 @@ test("Admin Browsing Groups", () => {
andThen(() => {
ok(find(".nav-stacked li a[title='Messages']").length === 1, 'it should show messages tab if user is admin');
ok(find(".nav-stacked li a[title='Edit Group']").length === 1, 'it should show edit group tab if user is admin');
ok(find(".nav-stacked li a[title='Logs']").length === 1, 'it should show Logs tab if user is admin');
equal(find('.group-title').text(), 'Awesome Team', 'it should display the group title');
equal(find('.group-name').text(), '@discourse', 'it should display the group name');
});
click('.group-edit-btn');
andThen(() => {
ok(find('.group-flair-inputs').length === 1, 'it should display avatar flair inputs');
ok(find('.edit-group-bio').length === 1, 'it should display group bio input');
ok(find('.edit-group-title').length === 1, 'it should display group title input');
ok(find('.edit-group-public').length === 1, 'it should display group public input');
ok(find('.edit-group-allow-membership-requests').length === 1, 'it should display group allow_membership_requets input');
});
click('.edit-group-public');
andThen(() => {
ok(find('.edit-group-allow-membership-requests[disabled]').length === 1, 'it should disable group allow_membership_requets input');
});
click('.edit-group-public');
click('.edit-group-allow-membership-requests');
andThen(() => {
ok(find('.edit-group-public[disabled]').length === 1, 'it should disable group public input');
});
});