github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-05-31 11:17:52 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

FIX: Can't update Groups#allow_membership_requests in admin.

Browse Source
This commit is contained in:
Guo Xiang Tan
2016-12-20 15:14:35 +08:00
parent c15bf62b43
commit 7c7c233c1c
3 changed files with 13 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
spec/controllers/admin/groups_controller_spec.rb
View File

@ -88,14 +88,19 @@ describe Admin::GroupsController do
it "ignore name change on automatic group" do
expect do
xhr :put, :update, { id: 1, group: { name: "WAT", visible: "true" } }
end.to_not change { GroupHistory.count }
xhr :put, :update, { id: 1, group: {
name: "WAT",
visible: "true",
allow_membership_requests: "true"
} }
end.to change { GroupHistory.count }.by(1)
expect(response).to be_success
group = Group.find(1)
expect(group.name).not_to eq("WAT")
expect(group.visible).to eq(true)
expect(group.allow_membership_requests).to eq(true)
end
it "doesn't launch the 'automatic group membership' job when it's not retroactive" do