DEV: Fix "ember/no-empty-glimmer-component-classes" lint (#24629)

app/assets/javascripts/admin/addon/components/admin-plugins-list.gjs

@@ -1,9 +1,7 @@
-import Component from "@glimmer/component";
 import i18n from "discourse-common/helpers/i18n";
 import AdminPluginsListItem from "./admin-plugins-list-item";
 
-export default class AdminPluginsList extends Component {
+const AdminPluginsList = <template>
-  <template>
   <table class="admin-plugins-list grid">
     <thead>
       <tr>
@@ -19,5 +17,6 @@ export default class AdminPluginsList extends Component {
       {{/each}}
     </tbody>
   </table>
-  </template>
+</template>;
-}
+
+export default AdminPluginsList;

app/assets/javascripts/admin/addon/components/dashboard-new-feature-item.gjs

@@ -1,23 +1,22 @@
-import Component from "@glimmer/component";
 import CookText from "discourse/components/cook-text";
 import i18n from "discourse-common/helpers/i18n";
 import and from "truth-helpers/helpers/and";
 import not from "truth-helpers/helpers/not";
 
-export default class DashboardNewFeatureItem extends Component {
+const DashboardNewFeatureItem = <template>
-  <template>
   <div class="admin-new-feature-item">
     <div class="admin-new-feature-item__content">
       <div class="admin-new-feature-item__header">
         {{#if (and @item.emoji (not @item.screenshot_url))}}
-            <div
+          <div class="admin-new-feature-item__new-feature-emoji">
-              class="admin-new-feature-item__new-feature-emoji"
+            {{@item.emoji}}
-            >{{@item.emoji}}</div>
+          </div>
         {{/if}}
         <h3>
           {{@item.title}}
         </h3>
       </div>
+
       {{#if @item.screenshot_url}}
         <img
           src={{@item.screenshot_url}}
@@ -25,8 +24,10 @@ export default class DashboardNewFeatureItem extends Component {
           alt={{@item.title}}
         />
       {{/if}}
+
       <div class="admin-new-feature-item__feature-description">
         <CookText @rawText={{@item.description}} />
+
         {{#if @item.link}}
           <a
             href={{@item.link}}
@@ -40,5 +41,6 @@ export default class DashboardNewFeatureItem extends Component {
       </div>
     </div>
   </div>
-  </template>
+</template>;
-}
+
+export default DashboardNewFeatureItem;

app/assets/javascripts/discourse/app/components/glimmer-component-with-deprecated-parent-view.js

@@ -36,6 +36,7 @@ class GlimmerComponentWithParentViewManager extends CustomComponentManager {
  * when building backwards-compatible versions of components. Any use of the parentView property
  * of the component should be considered deprecated.
  */
+// eslint-disable-next-line ember/no-empty-glimmer-component-classes
 export default class GlimmerComponentWithDeprecatedParentView extends Component {}
 
 setInternalComponentManager(

app/assets/javascripts/discourse/app/components/passkey-login-button.gjs

@@ -1,13 +1,12 @@
-import Component from "@glimmer/component";
 import DButton from "discourse/components/d-button";
 
-export default class PasskeyLoginButton extends Component {
+const PasskeyLoginButton = <template>
-  <template>
   <DButton
     @action={{@passkeyLogin}}
     @icon="user"
     @label="login.passkey.name"
-      class="btn btn-social passkey-login-button"
+    class="btn-social passkey-login-button"
   />
-  </template>
+</template>;
-}
+
+export default PasskeyLoginButton;

app/assets/javascripts/discourse/tests/integration/component-templates-test.gjs

@@ -9,9 +9,11 @@ import { forceMobile, resetMobile } from "discourse/lib/mobile";
 import { setupRenderingTest } from "discourse/tests/helpers/component-test";
 import { registerTemporaryModule } from "../helpers/temporary-module-helper";
 
+// eslint-disable-next-line ember/no-empty-glimmer-component-classes
 class MockColocatedComponent extends Component {}
 setComponentTemplate(hbs`Colocated Original`, MockColocatedComponent);
 
+// eslint-disable-next-line ember/no-empty-glimmer-component-classes
 class MockResolvedComponent extends Component {}
 const MockResolvedComponentTemplate = hbs`Resolved Original`;
 

plugins/chat/assets/javascripts/discourse/components/chat-composer-message-details.gjs

@@ -1,12 +1,10 @@
-import Component from "@glimmer/component";
 import DButton from "discourse/components/d-button";
 import replaceEmoji from "discourse/helpers/replace-emoji";
 import dIcon from "discourse-common/helpers/d-icon";
 import htmlSafe from "discourse-common/helpers/html-safe";
 import ChatUserAvatar from "./chat-user-avatar";
 
-export default class ChatComposerMessageDetails extends Component {
+const ChatComposerMessageDetails = <template>
-  <template>
   <div
     class="chat-composer-message-details"
     data-id={{@message.id}}
@@ -28,5 +26,6 @@ export default class ChatComposerMessageDetails extends Component {
       class="btn-flat cancel-message-action"
     />
   </div>
-  </template>
+</template>;
-}
+
+export default ChatComposerMessageDetails;

plugins/chat/assets/javascripts/discourse/components/chat-drawer/header/close-button.gjs

@@ -1,13 +1,12 @@
-import Component from "@glimmer/component";
 import DButton from "discourse/components/d-button";
 
-export default class extends Component {
+const CloseButton = <template>
-  <template>
   <DButton
     @icon="times"
     @action={{@close}}
     @title="chat.close"
     class="btn-flat btn-link chat-drawer-header__close-btn"
   />
-  </template>
+</template>;
-}
+
+export default CloseButton;

plugins/chat/assets/javascripts/discourse/components/chat-emoji-avatar.gjs

@@ -1,12 +1,11 @@
-import Component from "@glimmer/component";
 import replaceEmoji from "discourse/helpers/replace-emoji";
 
-export default class extends Component {
+const ChatEmojiAvatar = <template>
-  <template>
   <div class="chat-emoji-avatar">
     <div class="chat-emoji-avatar-container">
       {{replaceEmoji @emoji}}
     </div>
   </div>
-  </template>
+</template>;
-}
+
+export default ChatEmojiAvatar;

plugins/chat/assets/javascripts/discourse/components/chat-message-separator-new.gjs

@@ -1,10 +1,8 @@
-import Component from "@glimmer/component";
 import i18n from "discourse-common/helpers/i18n";
 import and from "truth-helpers/helpers/and";
 import not from "truth-helpers/helpers/not";
 
-export default class extends Component {
+const ChatMessageSeparatorNew = <template>
-  <template>
   {{#if (and @message.newest (not @message.formattedFirstMessageDate))}}
     <div class="chat-message-separator-new">
       <div class="chat-message-separator__text-container">
@@ -18,5 +16,6 @@ export default class extends Component {
       </div>
     </div>
   {{/if}}
-  </template>
+</template>;
-}
+
+export default ChatMessageSeparatorNew;

plugins/chat/assets/javascripts/discourse/components/chat-side-panel-resizer.gjs

@@ -1,7 +1,5 @@
-import Component from "@glimmer/component";
+const ChatSidePanelResizer = <template>
-
-export default class extends Component {
-  <template>
   <div class="chat-side-panel-resizer"></div>
-  </template>
+</template>;
-}
+
+export default ChatSidePanelResizer;

plugins/chat/assets/javascripts/discourse/components/chat/composer/button.gjs

@@ -1,12 +1,11 @@
-import Component from "@glimmer/component";
 import dIcon from "discourse-common/helpers/d-icon";
 
-export default class ChatComposerButton extends Component {
+const ChatComposerButton = <template>
-  <template>
   <div class="chat-composer-button__wrapper">
     <button type="button" class="chat-composer-button" ...attributes>
       {{dIcon @icon}}
     </button>
   </div>
-  </template>
+</template>;
-}
+
+export default ChatComposerButton;

plugins/chat/assets/javascripts/discourse/components/chat/composer/separator.gjs

@@ -1,7 +1,5 @@
-import Component from "@glimmer/component";
+const ChatComposerSeparator = <template>
-
-export default class ChatComposerSeparator extends Component {
-  <template>
   <div class="chat-composer-separator"></div>
-  </template>
+</template>;
-}
+
+export default ChatComposerSeparator;

plugins/chat/assets/javascripts/discourse/components/chat/form/row.gjs

@@ -1,18 +1,13 @@
-import Component from "@glimmer/component";
 import { LinkTo } from "@ember/routing";
 import concatClass from "discourse/helpers/concat-class";
 import icon from "discourse-common/helpers/d-icon";
 
-export default class ChatFormRow extends Component {
+const ChatFormRow = <template>
-  <template>
   {{#if @route}}
     <LinkTo
       @route={{@route}}
       @models={{@routeModels}}
-        class={{concatClass
+      class={{concatClass "chat-form__row -link" (if @separator "-separator")}}
-          "chat-form__row -link"
-          (if @separator "-separator")
-        }}
     >
       <div class="chat-form__row-content">
         {{@label}}
@@ -44,5 +39,6 @@ export default class ChatFormRow extends Component {
       {{/if}}
     </div>
   {{/if}}
-  </template>
+</template>;
-}
+
+export default ChatFormRow;

plugins/chat/assets/javascripts/discourse/components/chat/message-creator/list-action.gjs

@@ -1,12 +1,11 @@
-import Component from "@glimmer/component";
 import DButton from "discourse/components/d-button";
 
-export default class ListAction extends Component {
+const ListAction = <template>
-  <template>
   <DButton
     class="btn btn-flat"
     @icon={{@item.icon}}
     @translatedLabel={{@item.label}}
   />
-  </template>
+</template>;
-}
+
+export default ListAction;

plugins/chat/assets/javascripts/discourse/components/chat/message-creator/member.gjs

@@ -1,12 +1,10 @@
-import Component from "@glimmer/component";
 import { fn } from "@ember/helper";
 import DButton from "discourse/components/d-button";
 import concatClass from "discourse/helpers/concat-class";
 import icon from "discourse-common/helpers/d-icon";
 import ChatUserAvatar from "discourse/plugins/chat/discourse/components/chat-user-avatar";
 
-export default class Member extends Component {
+const Member = <template>
-  <template>
   <DButton
     class={{concatClass
       "chat-message-creator__member btn-default"
@@ -24,5 +22,6 @@ export default class Member extends Component {
     </span>
     {{icon "times"}}
   </DButton>
-  </template>
+</template>;
-}
+
+export default Member;

plugins/chat/assets/javascripts/discourse/components/chat/message/avatar.gjs

@@ -1,9 +1,7 @@
-import Component from "@glimmer/component";
 import ChatEmojiAvatar from "../../chat-emoji-avatar";
 import ChatUserAvatar from "../../chat-user-avatar";
 
-export default class extends Component {
+const Avatar = <template>
-  <template>
   <div class="chat-message-avatar">
     {{#if @message.chatWebhookEvent.emoji}}
       <ChatEmojiAvatar @emoji={{@message.chatWebhookEvent.emoji}} />
@@ -11,5 +9,6 @@ export default class extends Component {
       <ChatUserAvatar @user={{@message.user}} @avatarSize="medium" />
     {{/if}}
   </div>
-  </template>
+</template>;
-}
+
+export default Avatar;

plugins/chat/assets/javascripts/discourse/components/chat/message/error.gjs

@@ -1,11 +1,9 @@
-import Component from "@glimmer/component";
 import { fn } from "@ember/helper";
 import DButton from "discourse/components/d-button";
 import i18n from "discourse-common/helpers/i18n";
 import eq from "truth-helpers/helpers/eq";
 
-export default class extends Component {
+const Error = <template>
-  <template>
   {{#if @message.error}}
     <div class="chat-message-error">
       {{#if (eq @message.error "network_error")}}
@@ -26,5 +24,6 @@ export default class extends Component {
       {{/if}}
     </div>
   {{/if}}
-  </template>
+</template>;
-}
+
+export default Error;

plugins/chat/assets/javascripts/discourse/components/chat/scroll-to-bottom-arrow.gjs

@@ -1,10 +1,8 @@
-import Component from "@glimmer/component";
 import DButton from "discourse/components/d-button";
 import concatClass from "discourse/helpers/concat-class";
 import dIcon from "discourse-common/helpers/d-icon";
 
-export default class extends Component {
+const ScrollToBottomArrow = <template>
-  <template>
   <div class="chat-scroll-to-bottom">
     <DButton
       class={{concatClass
@@ -19,5 +17,6 @@ export default class extends Component {
       </span>
     </DButton>
   </div>
-  </template>
+</template>;
-}
+
+export default ScrollToBottomArrow;

plugins/chat/assets/javascripts/discourse/components/styleguide/organisms/chat.gjs

@@ -1,4 +1,3 @@
-import Component from "@glimmer/component";
 import ChatComposer from "../chat-composer";
 import ChatComposerMessageDetails from "../chat-composer-message-details";
 import ChatHeaderIcon from "../chat-header-icon";
@@ -15,8 +14,7 @@ import ChatModalThreadSettings from "../chat-modal-thread-settings";
 import ChatModalToggleChannelStatus from "../chat-modal-toggle-channel-status";
 import ChatThreadListItem from "../chat-thread-list-item";
 
-export default class extends Component {
+const ChatOrganism = <template>
-  <template>
   <ChatMessage />
   <ChatComposer />
   <ChatThreadListItem />
@@ -35,5 +33,6 @@ export default class extends Component {
   <ChatModalToggleChannelStatus />
   <ChatModalNewMessage />
   <ChatModalChannelSummary />
-  </template>
+</template>;
-}
+
+export default ChatOrganism;

plugins/styleguide/assets/javascripts/discourse/components/dummy-component.gjs

@@ -1,7 +1,5 @@
-import Component from "@glimmer/component";
+const DummyComponent = <template>
-
-export default class DummyComponent extends Component {
-  <template>
   My custom component with foo: {{@model.foo}}
-  </template>
+</template>;
-}
+
+export default DummyComponent;

plugins/styleguide/assets/javascripts/discourse/components/styleguide/component.js

@@ -1,3 +0,0 @@
-import Component from "@glimmer/component";
-
-export default class StyleguideComponent extends Component {}

plugins/styleguide/assets/javascripts/discourse/components/styleguide/controls.js

@@ -1,3 +0,0 @@
-import Component from "@glimmer/component";
-
-export default class StyleguideControls extends Component {}

plugins/styleguide/assets/javascripts/discourse/components/styleguide/controls/toggle.js

@@ -1,3 +0,0 @@
-import Component from "@glimmer/component";
-
-export default class StyleguideControlsToggle extends Component {}