github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-06-07 14:29:13 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

UX: Show spinning icon while group members load.

Browse Source
This commit is contained in:
Guo Xiang Tan
2017-01-03 14:58:14 +08:00
parent 3aed15c99e
commit 7ce4bc2e90
2 changed files with 12 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
app/assets/javascripts/discourse/controllers/group-index.js.es6
View File

@ -1,6 +1,6 @@
import { popupAjaxError } from 'discourse/lib/ajax-error'; import { popupAjaxError } from 'discourse/lib/ajax-error';
import Group from 'discourse/models/group'; import Group from 'discourse/models/group';
import { observes } from 'ember-addons/ember-computed-decorators'; import { default as computed, observes } from 'ember-addons/ember-computed-decorators';
export default Ember.Controller.extend({ export default Ember.Controller.extend({
queryParams: ['order', 'desc'], queryParams: ['order', 'desc'],
@ -14,8 +14,17 @@ export default Ember.Controller.extend({
@observes('order', 'desc') @observes('order', 'desc')
refreshMembers() { refreshMembers() {
this.set('loading', true);
this.get('model') && this.get('model') &&
this.get('model').findMembers({ order: this.get('order'), desc: this.get('desc') }); this.get('model')
.findMembers({ order: this.get('order'), desc: this.get('desc') })
.finally(() => this.set('loading', false));
},
@computed('model.members')
hasMembers(members) {
return members && members.length > 0;
}, },
actions: { actions: {

2
app/assets/javascripts/discourse/templates/group-index.hbs
View File

@ -1,4 +1,4 @@
{{#if model.members}} {{#if hasMembers}}
{{group-membership-button model=model {{group-membership-button model=model
createNewMessageViaParams='createNewMessageViaParams'}} createNewMessageViaParams='createNewMessageViaParams'}}