github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-05-22 07:20:45 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

FEATURE: Omit showing day when 'to' day is same as 'from' day (#18500)

Browse Source 
Essentially,

Saturday at 2:50 PM -> Saturday at 4:38 PM becomes
Saturday at 2:50 PM -> 4:38 PM (Singapore)

Also, the displayed dates are shortened when the standalone date
is within two days. So despite the 'from' and 'to' date being the
same day, it may show 'Saturday' for 'from', and the specific date
for the 'to'. This corrects the behaviour.

(so if the current date and time is Thursday 5PM, the 'from' date
below is within 2 days, but the 'to' date is not)
Saturday at 2:50 PM -> 8 October 2022 at 9:38 PM becomes
Saturday at 2:50 PM -> 9:38 PM
This commit is contained in:
Natalie Tay
2022-10-07 09:39:41 +08:00
committed by GitHub
parent cb26d52d33
commit 7d8cda9858
5 changed files with 61 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
plugins/discourse-local-dates/spec/integration/local_dates_spec.rb
View File

@ -91,7 +91,8 @@ RSpec.describe "Local Dates" do
cooked = Fabricate(:post, raw: raw).cooked
expect(cooked).to include('data-date="2022-01-06')
expect(cooked).to include('data-range="true"')
expect(cooked).to include('data-range="from"')
expect(cooked).to include('data-range="to"')
expect(cooked).not_to include('data-time=')
end
@ -100,7 +101,8 @@ RSpec.describe "Local Dates" do
cooked = Fabricate(:post, raw: raw).cooked
expect(cooked).to include('data-date="2022-01-06')
expect(cooked).to include('data-range="true"')
expect(cooked).to include('data-range="to"')
expect(cooked).to include('data-range="from"')
expect(cooked).to include('data-time="13:00"')
expect(cooked).to include('data-timezone="Australia/Sydney"')
end
@ -111,7 +113,7 @@ RSpec.describe "Local Dates" do
expect(cooked).to include('data-date="2022-01-06')
expect(cooked).to include('data-time="13:00"')
expect(cooked).not_to include('data-range=')
expect(cooked).not_to include('data-range="to"')
end
end
end