github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-05-31 16:57:16 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

DEV: Fix flaky user preferences interface system test (#21800)

Browse Source 
Why is this change required?

The flaky system test was due to the fact that we had to poll for the
user preferences interface page to reload after saving. However, this
turns out to be a bug on the user perferences interface page because the
page should only reload if the user has selected a new theme that is
different from the site's default but we were reloading the page for
users that did not have any user theme selected. Therefore there was an
unnecessary reload happening when saving other fields on the user
preferences interface page.
This commit is contained in:
Alan Guo Xiang Tan
2023-05-29 12:56:21 +09:00
committed by GitHub
parent 123a77a2bc
commit 7d9a823a55
5 changed files with 50 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files

31
spec/system/user_preferences_interface_spec.rb
View File

@ -3,34 +3,29 @@
describe "User preferences for Interface", type: :system, js: true do
fab!(:user) { Fabricate(:user) }
let(:user_preferences_page) { PageObjects::Pages::UserPreferences.new }
let(:user_preferences_interface_page) { PageObjects::Pages::UserPreferencesInterface.new }
before { sign_in(user) }
describe "Bookmarks" do
it "changes the bookmark after notification preference" do
user_preferences_page.visit(user)
click_link "Interface"
user_preferences_page.visit(user).click_interface_tab
# preselects the default user_option.bookmark_auto_delete_preference value of 3 (clear_reminder)
expect(page).to have_css(
"#boookmark-after-notification-mode .select-kit-header[data-value='#{Bookmark.auto_delete_preferences[:clear_reminder]}']",
expect(user_preferences_interface_page).to have_bookmark_after_notification_mode(
Bookmark.auto_delete_preferences[:clear_reminder],
)
page.find("#boookmark-after-notification-mode").click
page.find(
".select-kit-row[data-value=\"#{Bookmark.auto_delete_preferences[:when_reminder_sent]}\"]",
).click
click_button "Save Changes"
user_preferences_interface_page.select_bookmark_after_notification_mode(
Bookmark.auto_delete_preferences[:when_reminder_sent],
).save_changes
# the preference page reloads after saving, so we need to poll the db
try_until_success do
expect(
UserOption.exists?(
user_id: user.id,
bookmark_auto_delete_preference: Bookmark.auto_delete_preferences[:when_reminder_sent],
),
).to be_truthy
end
expect(
UserOption.exists?(
user_id: user.id,
bookmark_auto_delete_preference: Bookmark.auto_delete_preferences[:when_reminder_sent],
),
).to eq(true)
end
end
end