FIX: Password required flag should be cleared whenever clearing the raw password (#5384)

spec/components/validators/password_validator_spec.rb

@@ -134,6 +134,19 @@ describe PasswordValidator do
       validate
       expect(record.errors[:password]).to include(password_error_message(:same_as_current))
     end
+
+    it "validation required if password is required" do
+      expect(record.password_validation_required?).to eq(true)
+    end
+
+    it "validation not required after save until a new password is set" do
+      @password = "myoldpassword"
+      record.save!
+      record.reload
+      expect(record.password_validation_required?).to eq(false)
+      record.password = "mynewpassword"
+      expect(record.password_validation_required?).to eq(true)
+    end
   end
 
   context "password not required" do
@@ -144,6 +157,17 @@ describe PasswordValidator do
       validate
       expect(record.errors[:password]).not_to be_present
     end
+
+    it "validation required if a password is set" do
+      @password = "mygameshow"
+      expect(record.password_validation_required?).to eq(true)
+    end
+
+    it "adds an error even password not required" do
+      @password = "p"
+      validate
+      expect(record.errors[:password]).to be_present
+    end
   end
 
 end