github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-06-05 14:07:30 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

Refactor test case.

Browse Source
This commit is contained in:
Guo Xiang Tan
2018-03-19 13:39:29 +08:00
parent 9e8d10f711
commit 7fad30dacc
1 changed files with 11 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
spec/components/topic_query_spec.rb
View File

@ -166,26 +166,26 @@ describe TopicQuery do
end end
context "no category filter" do context "no category filter" do
# create some topics before each test:
let!(:tagged_topic1) { Fabricate(:topic, tags: [tag]) } let!(:tagged_topic1) { Fabricate(:topic, tags: [tag]) }
let!(:tagged_topic2) { Fabricate(:topic, tags: [other_tag]) } let!(:tagged_topic2) { Fabricate(:topic, tags: [other_tag]) }
let!(:tagged_topic3) { Fabricate(:topic, tags: [tag, other_tag]) } let!(:tagged_topic3) { Fabricate(:topic, tags: [tag, other_tag]) }
let!(:no_tags_topic) { Fabricate(:topic) } let!(:no_tags_topic) { Fabricate(:topic) }
it "returns topics with the tag when filtered to it" do it "returns topics with the tag when filtered to it" do
expect(TopicQuery.new(moderator, tags: [tag.name]).list_latest.topics.map(&:id).sort).to eq([tagged_topic1.id, tagged_topic3.id].sort) expect(TopicQuery.new(moderator, tags: [tag.name]).list_latest.topics)
expect(TopicQuery.new(moderator, tags: [tag.id]).list_latest.topics.map(&:id).sort).to eq([tagged_topic1.id, tagged_topic3.id].sort) .to contain_exactly(tagged_topic1, tagged_topic3)
two_tag_topic = TopicQuery.new(moderator, tags: [tag.name]).list_latest.topics.find { |t| t.id == tagged_topic3.id } expect(TopicQuery.new(moderator, tags: [tag.id]).list_latest.topics)
expect(two_tag_topic.tags.size).to eq(2) .to contain_exactly(tagged_topic1, tagged_topic3)
# topics with ANY of the given tags: expect(TopicQuery.new(
expect(TopicQuery.new(moderator, tags: [tag.name, other_tag.name]).list_latest.topics.map(&:id).sort).to eq([tagged_topic1.id, tagged_topic2.id, tagged_topic3.id].sort) moderator, tags: [tag.name, other_tag.name]
expect(TopicQuery.new(moderator, tags: [tag.id, other_tag.id]).list_latest.topics.map(&:id).sort).to eq([tagged_topic1.id, tagged_topic2.id, tagged_topic3.id].sort) ).list_latest.topics).to contain_exactly(
tagged_topic1, tagged_topic2, tagged_topic3
)
# TODO: topics with ALL of the given tags: expect(TopicQuery.new(moderator, tags: [tag.id, other_tag.id]).list_latest.topics)
# expect(TopicQuery.new(moderator, tags: [tag.name, other_tag.name]).list_latest.topics.map(&:id)).to eq([tagged_topic3.id].sort) .to contain_exactly(tagged_topic1, tagged_topic2, tagged_topic3)
# expect(TopicQuery.new(moderator, tags: [tag.id, other_tag.id]).list_latest.topics.map(&:id)).to eq([tagged_topic3.id].sort)
end end
it "can return topics with all specified tags" do it "can return topics with all specified tags" do