DEV: Plugin API to add directory columns (#13440)

spec/requests/directory_columns_controller_spec.rb

@@ -7,6 +7,17 @@ describe DirectoryColumnsController do
   fab!(:admin) { Fabricate(:admin) }
 
   describe "#index" do
+    it "returns all active directory columns" do
+      likes_given = DirectoryColumn.find_by(name: "likes_given")
+      likes_given.update(enabled: false)
+
+      get "/directory-columns.json"
+
+      expect(response.parsed_body["directory_columns"].map { |dc| dc["name"] }).not_to include("likes_given")
+    end
+  end
+
+  describe "#edit-index" do
     fab!(:public_user_field) { Fabricate(:user_field, show_on_profile: true) }
     fab!(:private_user_field) { Fabricate(:user_field, show_on_profile: false, show_on_user_card: false) }
 
@@ -14,13 +25,13 @@ describe DirectoryColumnsController do
       sign_in(admin)
 
       expect {
-        get "/directory-columns.json"
+        get "/edit-directory-columns.json"
       }.to change { DirectoryColumn.count }.by(1)
     end
 
     it "returns a 403 when not logged in as staff member" do
       sign_in(user)
-      get "/directory-columns.json"
+      get "/edit-directory-columns.json"
 
       expect(response.status).to eq(404)
     end
@@ -50,7 +61,7 @@ describe DirectoryColumnsController do
       sign_in(admin)
 
       expect {
-        put "/directory-columns.json", params: params
+        put "/edit-directory-columns.json", params: params
       }.to change { DirectoryColumn.find(first_directory_column_id).enabled }.from(true).to(false)
     end
 
@@ -59,14 +70,14 @@ describe DirectoryColumnsController do
       bad_params = params
       bad_params[:directory_columns][:"1"][:enabled] = false
 
-      put "/directory-columns.json", params: bad_params
+      put "/edit-directory-columns.json", params: bad_params
 
       expect(response.status).to eq(400)
     end
 
     it "returns a 404 when not logged in as a staff member" do
       sign_in(user)
-      put "/directory-columns.json", params: params
+      put "/edit-directory-columns.json", params: params
 
       expect(response.status).to eq(404)
     end