github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-06-01 09:05:53 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

DEV: Change upload verified column to be integer (#10643)

Browse Source 
Per review https://review.discourse.org/t/dev-add-verified-to-uploads-and-fill-in-s3-inventory-10406/14180

Change the verified column for Upload to a verified_status integer column, to avoid having NULL as a weird implicit status.
This commit is contained in:
Martin Brennan
2020-09-17 13:35:29 +10:00
committed by GitHub
parent e313aa5a6e
commit 80268357e7
6 changed files with 87 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
spec/components/s3_inventory_spec.rb
View File

@ -107,15 +107,15 @@ describe "S3Inventory" do
end
it "marks missing uploads as not verified and found uploads as verified. uploads not checked will be verified nil" do
expect(Upload.where(verified: nil).count).to eq(12)
expect(Upload.where(verification_status: Upload.verification_statuses[:unchecked]).count).to eq(12)
output = capture_stdout do
inventory.backfill_etags_and_list_missing
end
verified = Upload.pluck(:verified)
expect(Upload.where(verified: true).count).to eq(3)
expect(Upload.where(verified: false).count).to eq(2)
expect(Upload.where(verified: nil).count).to eq(7)
verification_status = Upload.pluck(:verification_status)
expect(Upload.where(verification_status: Upload.verification_statuses[:verified]).count).to eq(3)
expect(Upload.where(verification_status: Upload.verification_statuses[:invalid_etag]).count).to eq(2)
expect(Upload.where(verification_status: Upload.verification_statuses[:unchecked]).count).to eq(7)
end
it "does not affect the updated_at date of uploads" do