github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-06-06 23:07:28 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

UX: Fix user-select regressions (#31129)

Browse Source 
…and cases that didn't take webkit into account at all.
This commit is contained in:
Jarek Radosz
2025-02-03 18:14:11 +01:00
committed by GitHub
parent e55d00d405
commit 80d7075171
8 changed files with 18 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
app/assets/stylesheets/common/base/modal.scss
View File

@ -123,7 +123,7 @@
} }
&__backdrop { &__backdrop {
user-select: none; @include user-select(none);
position: fixed; position: fixed;
top: 0; top: 0;
right: 0; right: 0;
@ -150,7 +150,7 @@
} }
.modal-backdrop { .modal-backdrop {
user-select: none; @include user-select(none);
position: fixed; position: fixed;
top: 0; top: 0;
right: 0; right: 0;

2
app/assets/stylesheets/common/base/topic-post.scss
View File

@ -1285,7 +1285,7 @@ a.mention-group {
@include mention; @include mention;
.user-status-message { .user-status-message {
user-select: none; @include user-select(none);
} }
} }

1
app/assets/stylesheets/common/foundation/mixins.scss
View File

@ -124,6 +124,7 @@ $hpad: 0.65em;
// Unselectable (avoids unwanted selections with iPad, touch laptops, etc) // Unselectable (avoids unwanted selections with iPad, touch laptops, etc)
@mixin user-select($mode) { @mixin user-select($mode) {
-webkit-user-select: $mode;
user-select: $mode; user-select: $mode;
} }

2
app/assets/stylesheets/common/table-builder/table-edit-decorator.scss
View File

@ -1,6 +1,6 @@
.btn-edit-table { .btn-edit-table {
-webkit-touch-callout: none; -webkit-touch-callout: none;
user-select: none; @include user-select(none);
} }
.fullscreen-table-wrapper:hover .fullscreen-table-wrapper__buttons button { .fullscreen-table-wrapper:hover .fullscreen-table-wrapper__buttons button {

2
app/assets/stylesheets/wizard.scss
View File

@ -253,7 +253,7 @@ body.wizard {
background: var(--secondary); background: var(--secondary);
border-radius: 10px; border-radius: 10px;
cursor: grab; cursor: grab;
user-select: none; @include user-select(none);
&.dragging { &.dragging {
cursor: grabbing; cursor: grabbing;

2
plugins/chat/assets/stylesheets/mixins/chat-reaction.scss
View File

@ -8,7 +8,7 @@
border: 1px solid var(--primary-300); border: 1px solid var(--primary-300);
background: transparent; background: transparent;
cursor: pointer; cursor: pointer;
user-select: none; @include user-select(none);
transition: background 0.2s, border-color 0.2s; transition: background 0.2s, border-color 0.2s;
&.reacted { &.reacted {

2
plugins/footnote/assets/stylesheets/footnotes.scss
View File

@ -1,6 +1,6 @@
.inline-footnotes { .inline-footnotes {
a.expand-footnote { a.expand-footnote {
user-select: none; @include user-select(none);
padding: 0 0.5em; padding: 0 0.5em;
margin: 0 0 0 0.25em; margin: 0 0 0 0.25em;
color: var(--primary-low-mid-or-secondary-high); color: var(--primary-low-mid-or-secondary-high);

11
stylelint.config.mjs
View File

@ -11,7 +11,10 @@ export default {
"no-invalid-double-slash-comments": true, "no-invalid-double-slash-comments": true,
"no-empty-source": true, "no-empty-source": true,
"at-rule-empty-line-before": null, "at-rule-empty-line-before": null,
"rule-empty-line-before": ["always", {except: ["after-single-line-comment", "first-nested"]}], "rule-empty-line-before": [
"always",
{ except: ["after-single-line-comment", "first-nested"] },
],
"selector-class-pattern": null, "selector-class-pattern": null,
"custom-property-pattern": null, "custom-property-pattern": null,
"declaration-empty-line-before": "never", "declaration-empty-line-before": "never",
@ -40,5 +43,11 @@ export default {
"function-linear-gradient-no-nonstandard-direction": null, "function-linear-gradient-no-nonstandard-direction": null,
"scss/at-mixin-pattern": null, "scss/at-mixin-pattern": null,
"media-feature-range-notation": "prefix", "media-feature-range-notation": "prefix",
"property-no-vendor-prefix": [
true,
{
ignoreProperties: ["user-select"],
},
],
}, },
}; };