github-mirror/discourse
github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-04-29 06:24:38 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

Make it possible to set a site setting to empty string

Browse Source
This commit is contained in:
Neil Lalonde 2013-06-11 14:31:38 -04:00
parent 811a0df68b
commit 82b5f57e40
2 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
app/controllers/admin/site_settings_controller.rb
View File

@ -7,7 +7,7 @@ class Admin::SiteSettingsController < Admin::AdminController
end end
def update def update
params.require(:value) raise ActionController::ParameterMissing.new(:value) unless params.has_key?(:value)
SiteSetting.send("#{params[:id]}=", params[:value]) SiteSetting.send("#{params[:id]}=", params[:value])
render nothing: true render nothing: true
end end

8
spec/controllers/admin/site_settings_controller_spec.rb
View File

@ -34,10 +34,10 @@ describe Admin::SiteSettingsController do
xhr :put, :update, id: 'test_setting', value: 'hello' xhr :put, :update, id: 'test_setting', value: 'hello'
end end
# it 'allows value to be a blank string' do it 'allows value to be a blank string' do
# SiteSetting.expects(:'test_setting=').with('').once SiteSetting.expects(:'test_setting=').with('').once
# xhr :put, :update, id: 'test_setting', value: '' xhr :put, :update, id: 'test_setting', value: ''
# end end
end end
end end