github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-05-28 10:41:25 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

UX: -2/+2% change in stats should be no-change in dashboard

Browse Source
This commit is contained in:
Joffrey JAFFEUX
2018-05-28 10:55:42 +02:00
committed by GitHub
parent 754458e6a2
commit 82e5727287
2 changed files with 33 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
test/javascripts/models/report-test.js.es6
View File

@ -84,7 +84,7 @@ QUnit.test("sevenDaysTrend", assert => {
report = reportWithData([0, 1,1,1,1,1,1,0, 1,1,1,1,1,1,1]);
trend = report.get("sevenDaysTrend");
assert.ok(trend === "trending-down");;
assert.ok(trend === "trending-down");
});
QUnit.test("yesterdayTrend", assert => {
@ -109,7 +109,7 @@ QUnit.test("yesterdayTrend", assert => {
report = reportWithData([0, 1, 1.1]);
trend = report.get("yesterdayTrend");
assert.ok(trend === "trending-down");;
assert.ok(trend === "trending-down");
});
QUnit.test("thirtyDaysTrend", assert => {
@ -139,7 +139,7 @@ QUnit.test("thirtyDaysTrend", assert => {
report = reportWithData([0, 1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,0]);
report.set("prev30Days", 35);
trend = report.get("thirtyDaysTrend");
assert.ok(trend === "trending-down");;
assert.ok(trend === "trending-down");
});
QUnit.test("higher is better false", assert => {
@ -164,7 +164,20 @@ QUnit.test("higher is better false", assert => {
report = reportWithData([0, 1, 1.1]);
report.set("higher_is_better", false);
trend = report.get("yesterdayTrend");
assert.ok(trend === "trending-up");;
assert.ok(trend === "trending-up");
});
QUnit.test("small variation (-2/+2% change) is no-change", assert => {
let report;
let trend;
report = reportWithData([0, 1,1,1,1,1,1,0.9, 1,1,1,1,1,1,1]);
trend = report.get("sevenDaysTrend");
assert.ok(trend === "no-change");
report = reportWithData([0, 1,1,1,1,1,1,1.1, 1,1,1,1,1,1,1]);
trend = report.get("sevenDaysTrend");
assert.ok(trend === "no-change");
});
QUnit.test("average", assert => {