github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-05-24 03:36:18 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

FEATURE: Remove support for legacy navigation menu (#23752)

Browse Source 
Why this change?

Back in May 17 2023 along with the release of Discourse 3.1, we announced
on meta that the legacy hamburger dropdown navigation menu is
deprecated and will be dropped in Discourse 3.2. This is the link to the announcement
on meta: https://meta.discourse.org/t/removing-the-legacy-hamburger-navigation-menu-option/265274

## What does this change do?

This change removes the `legacy` option from the `navigation_menu` site
setting and migrates existing sites on the `legacy` option to the
`header dropdown` option.

All references to the `legacy` option in code and tests have been
removed as well.
This commit is contained in:
Alan Guo Xiang Tan
2023-10-09 07:24:10 +08:00
committed by GitHub
parent 2c346a1ba6
commit 832b3b9e60
54 changed files with 116 additions and 411 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
spec/models/admin_dashboard_data_spec.rb
View File

@ -45,18 +45,6 @@ RSpec.describe AdminDashboardData do
expect(problems.map(&:to_s)).to include("a problem was found")
end
end
describe "when `navigation_menu` site setting is `legacy`" do
it "should include the right problem message" do
SiteSetting.set(:navigation_menu, "legacy")
problem = AdminDashboardData.fetch_problems.last
expect(problem.message).to include(
I18n.t("dashboard.legacy_navigation_menu_deprecated", base_path: Discourse.base_path),
)
end
end
end
describe "adding scheduled checks" do