From 83604154530d4bc796e2d7f0908f48b94f970edc Mon Sep 17 00:00:00 2001 From: Sam Saffron Date: Tue, 21 May 2019 16:11:38 +1000 Subject: [PATCH] FEATURE: big warning for uploads missing which can be very very slow on S3 --- lib/tasks/uploads.rake | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/lib/tasks/uploads.rake b/lib/tasks/uploads.rake index a6442249d7b..03f7426e6bc 100644 --- a/lib/tasks/uploads.rake +++ b/lib/tasks/uploads.rake @@ -592,6 +592,17 @@ task "uploads:missing" => :environment do if ENV["SKIP_EXTERNAL"] == "1" && Discourse.store.external? puts "#{RailsMultisite::ConnectionManagement.current_db} has uploads stored externally skipping!" else + if Discourse.store.external? + puts "-" * 80 + puts "WARNING! WARNING! WARNING!" + puts "-" * 80 + puts + puts <<~TEXT + #{RailsMultisite::ConnectionManagement.current_db} has uploads on S3! + validating without inventory is likely to take an enormous amount of time. + We recommend you run SKIP_EXTERNAL=1 rake uploads:missing to skip validating if on a multisite. + TEXT + end list_missing_uploads(skip_optimized: ENV['SKIP_OPTIMIZED']) end end