github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-05-28 13:51:18 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

DEV: Avoid waiting full capybara default wait time (#21842)

Browse Source 
Avoid using negated matchers with custom RSpec matchers that rely on
`has_css?` as it'll result in Capybara waiting the full default wait
time.
This commit is contained in:
Alan Guo Xiang Tan
2023-05-31 08:00:16 +09:00
committed by GitHub
parent 852086e888
commit 83af25179d
2 changed files with 16 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
spec/system/page_objects/components/composer.rb
View File

@ -103,8 +103,14 @@ module PageObjects
page.has_no_css?(emoji_preview_selector(emoji))
end
COMPOSER_INPUT_SELECTOR = "#{COMPOSER_ID} .d-editor-input"
def has_no_composer_input?
page.has_no_css?(COMPOSER_INPUT_SELECTOR)
end
def has_composer_input?
page.has_css?("#{COMPOSER_ID} .d-editor .d-editor-input")
page.has_css?(COMPOSER_INPUT_SELECTOR)
end
def has_form_template?
@ -115,8 +121,14 @@ module PageObjects
page.has_css?(".form-template-field[data-field-type='#{field}']")
end
FORM_TEMPLATE_CHOOSER_SELECTOR = ".composer-select-form-template"
def has_no_form_template_chooser?
page.has_no_css?(FORM_TEMPLATE_CHOOSER_SELECTOR)
end
def has_form_template_chooser?
page.has_css?(".composer-select-form-template")
page.has_css?(FORM_TEMPLATE_CHOOSER_SELECTOR)
end
def composer_input