Merge pull request #1249 from sir-pinecone/strip-spaces-from-group

Strip spaces from group names upon creation

app/controllers/admin/groups_controller.rb

@@ -31,7 +31,7 @@ class Admin::GroupsController < Admin::AdminController
 
   def create
     group = Group.new
-    group.name = params[:group][:name]
+    group.name = params[:group][:name].strip
     group.usernames = params[:group][:usernames] if params[:group][:usernames]
     if group.save
       render_serialized(group, BasicGroupSerializer)

spec/controllers/admin/groups_controller_spec.rb

@@ -48,9 +48,12 @@ describe Admin::GroupsController do
     end
   end
 
+  context '.create' do
+    let(:usernames) { @admin.username }
+
     it "is able to create a group" do
       xhr :post, :create, group: {
-      usernames: @admin.username,
+        usernames: usernames,
         name: "bob"
       }
 
@@ -59,10 +62,21 @@ describe Admin::GroupsController do
       groups = Group.where(name: "bob").to_a
 
       groups.count.should == 1
-    groups[0].usernames.should == @admin.username
+      groups[0].usernames.should == usernames
       groups[0].name.should == "bob"
     end
 
+    it "strips spaces from group name" do
+      lambda {
+        xhr :post, :create, group: {
+          usernames: usernames,
+          name: " bob "
+        }
+      }.should_not raise_error(ActiveRecord::RecordInvalid)
+      Group.where(name: "bob").count.should == 1
+    end
+  end
+
   it "is able to update group members" do
     user1 = Fabricate(:user)
     user2 = Fabricate(:user)