github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-06-01 03:35:15 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

FEATURE: Ability to scrub titles when importing embeddable content

Browse Source
This commit is contained in:
Robin Ward
2016-08-22 12:43:02 -04:00
parent aff1efc1f8
commit 884bdf7240
8 changed files with 45 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

29
spec/models/topic_embed_spec.rb
View File

@ -62,6 +62,31 @@ describe TopicEmbed do
describe '.find_remote' do
context ".title_scrub" do
let(:url) { 'http://eviltrout.com/123' }
let(:contents) { "<title>Through the Looking Glass - Classic Books</title><body>some content here</body>" }
let!(:embeddable_host) { Fabricate(:embeddable_host) }
let!(:file) { StringIO.new }
before do
file.stubs(:read).returns contents
TopicEmbed.stubs(:open).returns file
end
it "doesn't scrub the title by default" do
title, _ = TopicEmbed.find_remote(url)
expect(title).to eq("Through the Looking Glass - Classic Books")
end
it "scrubs the title when the option is enabled" do
SiteSetting.embed_title_scrubber = " - Classic Books$"
title, _ = TopicEmbed.find_remote(url)
expect(title).to eq("Through the Looking Glass")
end
end
context 'post with allowed classes "foo" and "emoji"' do
let(:user) { Fabricate(:user) }
@ -76,7 +101,7 @@ describe TopicEmbed do
SiteSetting.stubs(:embed_classname_whitelist).returns 'emoji , foo'
file.stubs(:read).returns contents
TopicEmbed.stubs(:open).returns file
title, content = TopicEmbed.find_remote(url)
_, content = TopicEmbed.find_remote(url)
end
it 'img node has emoji class' do
@ -111,7 +136,7 @@ describe TopicEmbed do
SiteSetting.stubs(:embed_classname_whitelist).returns ' '
file.stubs(:read).returns contents
TopicEmbed.stubs(:open).returns file
title, content = TopicEmbed.find_remote(url)
_, content = TopicEmbed.find_remote(url)
end
it 'img node doesn\'t have emoji class' do