github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-06-22 23:35:36 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

DEV: Rails 5.2 upgrade and global gem upgrade

Browse Source 
This updates tests to use latest rails 5 practice
and updates ALL dependencies that could be updated

Performance testing shows that performance has not regressed
if anything it is marginally faster now.
This commit is contained in:
Sam
2018-06-05 17:29:17 +10:00
parent 2bd905c632
commit 89ad2b5900
103 changed files with 900 additions and 864 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
spec/controllers/admin/user_fields_controller_spec.rb
View File

@ -16,7 +16,7 @@ describe Admin::UserFieldsController do
user_field: { name: 'hello', description: 'hello desc', field_type: 'text' }
}, format: :json
expect(response).to be_success
expect(response).to be_successful
}.to change(UserField, :count).by(1)
end
@ -31,7 +31,7 @@ describe Admin::UserFieldsController do
}
}, format: :json
expect(response).to be_success
expect(response).to be_successful
end.to change(UserField, :count).by(1)
expect(UserFieldOption.count).to eq(3)
@ -43,7 +43,7 @@ describe Admin::UserFieldsController do
it "returns a list of user fields" do
get :index, format: :json
expect(response).to be_success
expect(response).to be_successful
json = ::JSON.parse(response.body)
expect(json['user_fields']).to be_present
end
@ -55,7 +55,7 @@ describe Admin::UserFieldsController do
it "deletes the user field" do
expect {
delete :destroy, params: { id: user_field.id }, format: :json
expect(response).to be_success
expect(response).to be_successful
}.to change(UserField, :count).by(-1)
end
end
@ -69,7 +69,7 @@ describe Admin::UserFieldsController do
user_field: { name: 'fraggle', field_type: 'confirm', description: 'muppet' }
}, format: :json
expect(response).to be_success
expect(response).to be_successful
user_field.reload
expect(user_field.name).to eq('fraggle')
expect(user_field.field_type).to eq('confirm')
@ -86,7 +86,7 @@ describe Admin::UserFieldsController do
}
}, format: :json
expect(response).to be_success
expect(response).to be_successful
user_field.reload
expect(user_field.name).to eq('fraggle')
expect(user_field.field_type).to eq('dropdown')
@ -105,7 +105,7 @@ describe Admin::UserFieldsController do
}
}, format: :json
expect(response).to be_success
expect(response).to be_successful
user_field.reload
expect(user_field.user_field_options.size).to eq(2)
@ -119,7 +119,7 @@ describe Admin::UserFieldsController do
}
}, format: :json
expect(response).to be_success
expect(response).to be_successful
user_field.reload
expect(user_field.user_field_options.size).to eq(2)
end