github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-05-28 13:51:18 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

FIX: value-list choices when removing a value

Browse Source 
Fixes an issue where choices were broken when removing an item from the value-list component.

Adds test case for this scenario.
This commit is contained in:
Penar Musaraj
2020-02-14 11:21:06 -05:00
parent dafa354d3d
commit 89d9704194
2 changed files with 10 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
app/assets/javascripts/admin/components/value-list.js.es6
View File

@ -73,11 +73,10 @@ export default Component.extend({
_removeValue(value) { _removeValue(value) {
this.collection.removeObject(value); this.collection.removeObject(value);
const item = { id: value, name: value };
if (this.choices) { if (this.choices) {
this.choices.addObject(item); this.set("choices", this.choices.push(value).uniq());
} else { } else {
this.set("choices", makeArray(item)); this.set("choices", makeArray(value));
} }
this._saveValues(); this._saveValues();

8
test/javascripts/components/value-list-test.js.es6
View File

@ -45,6 +45,14 @@ componentTest("removing a value", {
); );
assert.equal(this.values, "osama", "it removes the expected value"); assert.equal(this.values, "osama", "it removes the expected value");
await selectKit().expand();
assert.ok(
find(".select-kit-collection li.select-kit-row span.name")[0]
.innerText === "vinkas",
"it adds the removed value to choices"
);
} }
}); });