github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-05-21 18:12:32 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

DEV: Revert the addition of keywords for all site settings. (#30755)

Browse Source 
This is a revert of 92793c5b73871ba84b024c2ce50055a0776f1ba6.

Following on from discussions after the previous commit, it became evident that it was only a small step towards solving the larger problem of finding site settings in a reliable fashion across multiple languages.

This is going to take more thought and discussion, and since the changes  introduced in the previous commit are effectively non functional without additional work, I'm going to revert it for now.
This commit is contained in:
Gary Pendergast
2025-01-14 13:34:04 +11:00
committed by GitHub
parent 9ce2ad14d1
commit 8c86676fcf
4 changed files with 0 additions and 889 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
spec/lib/site_setting_extension_spec.rb
View File

@ -1046,14 +1046,6 @@ RSpec.describe SiteSettingExtension do
)
end
it "has a keyword entry for all settings" do
SiteSetting.all_settings.each do |s|
next if s[:plugin] == SiteSetting::SAMPLE_TEST_PLUGIN.name
expect(I18n.exists?("site_settings.keywords.#{s[:setting]}")).to eq(true),
"Missing keyword entry for #{s[:setting]}"
end
end
context "when a setting also has an alias after renaming" do
before { SiteSetting.stubs(:deprecated_setting_alias).returns("some_old_setting") }