From 8ca8a7edba1ab66eb401249b36b10fc470bedff4 Mon Sep 17 00:00:00 2001 From: Sam Saffron Date: Mon, 31 Aug 2020 08:52:01 +1000 Subject: [PATCH] DEV: Lint file Ruby in warning mode complains about `foo *[]` instead `foo(*[])` is preferred --- app/models/user.rb | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/app/models/user.rb b/app/models/user.rb index 7f64e5a48b3..8e73356212e 100644 --- a/app/models/user.rb +++ b/app/models/user.rb @@ -273,8 +273,8 @@ class User < ActiveRecord::Base def self.editable_user_custom_fields(by_staff: false) fields = [] - fields.push *DiscoursePluginRegistry.self_editable_user_custom_fields - fields.push *DiscoursePluginRegistry.staff_editable_user_custom_fields if by_staff + fields.push(*DiscoursePluginRegistry.self_editable_user_custom_fields) + fields.push(*DiscoursePluginRegistry.staff_editable_user_custom_fields) if by_staff fields.uniq end @@ -297,18 +297,18 @@ class User < ActiveRecord::Base def self.allowed_user_custom_fields(guardian) fields = [] - fields.push *DiscoursePluginRegistry.public_user_custom_fields + fields.push(*DiscoursePluginRegistry.public_user_custom_fields) if SiteSetting.public_user_custom_fields.present? - fields.push *SiteSetting.public_user_custom_fields.split('|') + fields.push(*SiteSetting.public_user_custom_fields.split('|')) end if guardian.is_staff? if SiteSetting.staff_user_custom_fields.present? - fields.push *SiteSetting.staff_user_custom_fields.split('|') + fields.push(*SiteSetting.staff_user_custom_fields.split('|')) end - fields.push *DiscoursePluginRegistry.staff_user_custom_fields + fields.push(*DiscoursePluginRegistry.staff_user_custom_fields) end fields.uniq