github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-06-07 09:24:44 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

FEATURE: Allow editing bookmark reminders (#9437)

Browse Source 
Users can now edit the bookmark name and reminder time from their list of bookmarks.

We use "Custom" for the date and time in the modal because if the user set a reminder for "tomorrow" then edit the reminder "tomorrow", the definition of what "tomorrow" is has changed.
This commit is contained in:
Martin Brennan
2020-04-17 11:08:07 +10:00
committed by GitHub
parent 6fad04635b
commit 8f0544137a
14 changed files with 305 additions and 113 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
test/javascripts/controllers/bookmark-test.js
View File

@ -1,6 +1,7 @@
import { logIn } from "helpers/qunit-helpers";
import User from "discourse/models/user";
import KeyboardShortcutInitializer from "discourse/initializers/keyboard-shortcuts";
import { REMINDER_TYPES } from "discourse/lib/bookmark";
let BookmarkController;
moduleFor("controller:bookmark", {
@ -263,3 +264,20 @@ QUnit.test("user timezone updates when the modal is shown", function(assert) {
);
stub.restore();
});
QUnit.test(
"opening the modal with an existing bookmark with reminder at prefills the custom reminder type",
function(assert) {
let name = "test";
let reminderAt = "2020-05-15T09:45:00";
BookmarkController.model = { id: 1, name: name, reminderAt: reminderAt };
BookmarkController.onShow();
assert.equal(
BookmarkController.selectedReminderType,
REMINDER_TYPES.CUSTOM
);
assert.equal(BookmarkController.customReminderDate, "2020-05-15");
assert.equal(BookmarkController.customReminderTime, "09:45");
assert.equal(BookmarkController.model.name, name);
}
);