diff --git a/.template-lintrc.js b/.template-lintrc.js
index e467fa2784d..5731778fc04 100644
--- a/.template-lintrc.js
+++ b/.template-lintrc.js
@@ -5,6 +5,7 @@ module.exports = {
rules: {
"self-closing-void-elements": true,
"table-groups": true,
- "style-concatenation": true
+ "style-concatenation": true,
+ "no-invalid-interactive": true
}
};
diff --git a/app/assets/javascripts/admin/templates/api-keys-show.hbs b/app/assets/javascripts/admin/templates/api-keys-show.hbs
index 098d727f826..b96bc109b38 100644
--- a/app/assets/javascripts/admin/templates/api-keys-show.hbs
+++ b/app/assets/javascripts/admin/templates/api-keys-show.hbs
@@ -13,7 +13,9 @@
{{#if editingDescription}}
{{input value=buffered.description maxlength="255" placeholder=(i18n "admin.api.description_placeholder")}}
{{else}}
- {{if model.description model.description (i18n "admin.api.no_description")}}
+
+ {{if model.description model.description (i18n "admin.api.no_description")}}
+
{{/if}}
diff --git a/app/assets/javascripts/admin/templates/components/admin-theme-editor.hbs b/app/assets/javascripts/admin/templates/components/admin-theme-editor.hbs
index 049563bd555..bf9d2fd3cbc 100644
--- a/app/assets/javascripts/admin/templates/components/admin-theme-editor.hbs
+++ b/app/assets/javascripts/admin/templates/components/admin-theme-editor.hbs
@@ -4,11 +4,11 @@
{{#each visibleTargets as |target|}}
{{#link-to editRouteName
- theme.id
- target.name
- fieldName
- replace=true
- title=field.title
+ theme.id
+ target.name
+ fieldName
+ replace=true
+ title=field.title
class=(if target.edited 'edited' 'blank')
}}
{{#if target.error}}{{d-icon 'exclamation-triangle'}}{{/if}}
@@ -19,14 +19,15 @@
{{/link-to}}
{{/each}}
-
+
{{#if allowAdvanced}}
-
- {{d-icon (if showAdvanced "angle-double-left" "angle-double-right")}}
+ {{d-icon (if showAdvanced "angle-double-left" "angle-double-right")}}
{{/if}}
@@ -48,17 +49,17 @@
{{#each visibleFields as |field|}}
{{#link-to editRouteName
- theme.id
- currentTargetName
- field.name
- replace=true
- title=field.title
+ theme.id
+ currentTargetName
+ field.name
+ replace=true
+ title=field.title
class=(if field.edited 'edited' 'blank')
}}
{{#if field.error}}{{d-icon 'exclamation-triangle'}}{{/if}}
{{#if field.icon}}{{d-icon field.icon}}{{/if}}
{{field.translatedName}}
-
+
{{/link-to}}
{{/each}}
@@ -66,11 +67,11 @@
{{#if showAddField}}
{{#if addingField}}
- {{input type=text value=newFieldName enter=(action 'addField') escape-press=(action "cancelAddField")}}
- {{d-button class="ok" action=(action "addField" newFieldName) icon="check"}}
+ {{input type=text value=newFieldName enter=(action 'addField') escape-press=(action "cancelAddField")}}
+ {{d-button class="ok" action=(action "addField" newFieldName) icon="check"}}
{{d-button class="cancel" action=(action "cancelAddField") icon="times"}}
{{else}}
-
+
{{d-icon "plus"}}
{{/if}}
@@ -78,8 +79,8 @@
{{/if}}
-
- {{d-icon maximizeIcon}}
+
+ {{d-icon maximizeIcon}}
diff --git a/app/assets/javascripts/admin/templates/components/site-setting.hbs b/app/assets/javascripts/admin/templates/components/site-setting.hbs
index e67af557517..649df86a4fc 100644
--- a/app/assets/javascripts/admin/templates/components/site-setting.hbs
+++ b/app/assets/javascripts/admin/templates/components/site-setting.hbs
@@ -1,7 +1,7 @@
{{/if}}
diff --git a/app/assets/javascripts/admin/templates/components/themes-list.hbs b/app/assets/javascripts/admin/templates/components/themes-list.hbs
index 1f0c7fc2d54..29935b95b8c 100644
--- a/app/assets/javascripts/admin/templates/components/themes-list.hbs
+++ b/app/assets/javascripts/admin/templates/components/themes-list.hbs
@@ -1,10 +1,17 @@
diff --git a/app/assets/javascripts/admin/templates/customize-themes-show.hbs b/app/assets/javascripts/admin/templates/customize-themes-show.hbs
index 092991f1a32..de6b46da746 100644
--- a/app/assets/javascripts/admin/templates/customize-themes-show.hbs
+++ b/app/assets/javascripts/admin/templates/customize-themes-show.hbs
@@ -3,9 +3,13 @@
{{#if editingName}}
{{text-field value=model.name autofocus="true"}}
{{d-button action=(action "finishedEditingName") class="btn-primary submit-edit" icon="check"}}
- {{d-button action=(action "cancelEditingName") class="btn-default cancel-edit" icon="times"}}
+ {{d-button action=(action "cancelEditingName") class="cancel-edit" icon="times"}}
{{else}}
- {{model.name}}
{{d-icon "pencil-alt"}}
+
{{model.name}}
+ {{d-button
+ action=(action "startEditingName")
+ icon="pencil-alt"
+ }}
{{/if}}
diff --git a/app/assets/javascripts/admin/templates/email-bounced.hbs b/app/assets/javascripts/admin/templates/email-bounced.hbs
index 700f3907e99..0387050d8fc 100644
--- a/app/assets/javascripts/admin/templates/email-bounced.hbs
+++ b/app/assets/javascripts/admin/templates/email-bounced.hbs
@@ -29,7 +29,7 @@
{{l.to_address}} |
{{#if l.has_bounce_key}}
-
{{l.email_type}} |
+
{{l.email_type}} |
{{else}}
{{l.email_type}} |
{{/if}}
diff --git a/app/assets/javascripts/admin/templates/email-rejected.hbs b/app/assets/javascripts/admin/templates/email-rejected.hbs
index 7139d85e2fb..e3595a58bd2 100644
--- a/app/assets/javascripts/admin/templates/email-rejected.hbs
+++ b/app/assets/javascripts/admin/templates/email-rejected.hbs
@@ -48,7 +48,7 @@
{{email.subject}} |
- {{email.error}}
+ {{email.error}}
|
{{else}}
diff --git a/app/assets/javascripts/admin/templates/logs/screened-ip-addresses.hbs b/app/assets/javascripts/admin/templates/logs/screened-ip-addresses.hbs
index 109e7e32e1a..f9220965a2b 100644
--- a/app/assets/javascripts/admin/templates/logs/screened-ip-addresses.hbs
+++ b/app/assets/javascripts/admin/templates/logs/screened-ip-addresses.hbs
@@ -42,13 +42,13 @@
{{#if item.editing}}
{{text-field value=item.ip_address autofocus="autofocus"}}
{{else}}
-
+
{{#if item.isRange}}
{{item.ip_address}}
{{else}}
{{item.ip_address}}
{{/if}}
-
+
{{/if}}
@@ -108,7 +108,7 @@
action=(action "save")
actionParam=item
label="admin.logs.save"}}
- {{i18n "cancel"}}
+ {{i18n "cancel"}}
{{/unless}}
|
diff --git a/app/assets/javascripts/admin/templates/logs/staff-action-logs.hbs b/app/assets/javascripts/admin/templates/logs/staff-action-logs.hbs
index d48127916ac..57eb988901c 100644
--- a/app/assets/javascripts/admin/templates/logs/staff-action-logs.hbs
+++ b/app/assets/javascripts/admin/templates/logs/staff-action-logs.hbs
@@ -1,29 +1,29 @@
{{#if filtersExists}}
-
+
{{i18n 'admin.logs.staff_actions.clear_filters'}}
{{#if actionFilter}}
-
+
{{i18n 'admin.logs.action'}}: {{actionFilter}}
{{d-icon "times-circle"}}
{{/if}}
{{#if filters.acting_user}}
-
+
{{i18n 'admin.logs.staff_actions.staff_user'}}: {{filters.acting_user}}
{{d-icon "times-circle"}}
{{/if}}
{{#if filters.target_user}}
-
+
{{i18n 'admin.logs.staff_actions.target_user'}}: {{filters.target_user}}
{{d-icon "times-circle"}}
{{/if}}
{{#if filters.subject}}
-
+
{{i18n 'admin.logs.staff_actions.subject'}}: {{filters.subject}}
{{d-icon "times-circle"}}
@@ -63,7 +63,7 @@
- {{item.actionName}}
+ {{item.actionName}}
|
|
@@ -89,10 +89,10 @@
{{{item.formattedDetails}}}
{{#if item.useCustomModalForDetails}}
- {{d-icon "info-circle"}} {{i18n 'admin.logs.staff_actions.show'}}
+ {{d-icon "info-circle"}} {{i18n 'admin.logs.staff_actions.show'}}
{{/if}}
{{#if item.useModalForDetails}}
- {{d-icon "info-circle"}} {{i18n 'admin.logs.staff_actions.show'}}
+ {{d-icon "info-circle"}} {{i18n 'admin.logs.staff_actions.show'}}
{{/if}}
|
{{item.context}} |
diff --git a/app/assets/javascripts/admin/templates/modal/admin-uploaded-image-list.hbs b/app/assets/javascripts/admin/templates/modal/admin-uploaded-image-list.hbs
index 10af81306cb..178f39075ce 100644
--- a/app/assets/javascripts/admin/templates/modal/admin-uploaded-image-list.hbs
+++ b/app/assets/javascripts/admin/templates/modal/admin-uploaded-image-list.hbs
@@ -1,9 +1,9 @@
{{#d-modal-body class="uploaded-image-list"}}
{{#each images as |image|}}
-
+
{{else}}
{{i18n "admin.site_settings.uploaded_image_list.empty"}}
{{/each}}
diff --git a/app/assets/javascripts/admin/templates/web-hooks-show-events.hbs b/app/assets/javascripts/admin/templates/web-hooks-show-events.hbs
index 5b7b1e8e37c..38e4d2215fb 100644
--- a/app/assets/javascripts/admin/templates/web-hooks-show-events.hbs
+++ b/app/assets/javascripts/admin/templates/web-hooks-show-events.hbs
@@ -21,9 +21,9 @@
{{#if hasIncoming}}
-
+
{{/if}}
{{#each model as |webHookEvent|}}
diff --git a/app/assets/javascripts/discourse/templates/components/basic-topic-list.hbs b/app/assets/javascripts/discourse/templates/components/basic-topic-list.hbs
index 44d9dc579d8..b047846db56 100644
--- a/app/assets/javascripts/discourse/templates/components/basic-topic-list.hbs
+++ b/app/assets/javascripts/discourse/templates/components/basic-topic-list.hbs
@@ -1,11 +1,9 @@
{{#conditional-loading-spinner condition=loading}}
{{#if hasIncoming}}
{{/if}}
diff --git a/app/assets/javascripts/discourse/templates/components/composer-user-selector.hbs b/app/assets/javascripts/discourse/templates/components/composer-user-selector.hbs
index 21c69bda7ad..bf894877412 100644
--- a/app/assets/javascripts/discourse/templates/components/composer-user-selector.hbs
+++ b/app/assets/javascripts/discourse/templates/components/composer-user-selector.hbs
@@ -10,8 +10,10 @@
allowEmails='true'
autocomplete="discourse"}}
{{else}}
-
- {{limitedUsernames}}
- {{hiddenUsersCount}}
-
+
+
+ {{limitedUsernames}}
+ {{hiddenUsersCount}}
+
+
{{/if}}
diff --git a/app/assets/javascripts/discourse/templates/components/d-modal-cancel.hbs b/app/assets/javascripts/discourse/templates/components/d-modal-cancel.hbs
index e4fc5950d95..f61b3ed7c7c 100644
--- a/app/assets/javascripts/discourse/templates/components/d-modal-cancel.hbs
+++ b/app/assets/javascripts/discourse/templates/components/d-modal-cancel.hbs
@@ -1 +1 @@
-{{i18n 'cancel'}}
+{{i18n 'cancel'}}
diff --git a/app/assets/javascripts/discourse/templates/components/expand-post.hbs b/app/assets/javascripts/discourse/templates/components/expand-post.hbs
index 63716b696c1..ffb1ea66134 100644
--- a/app/assets/javascripts/discourse/templates/components/expand-post.hbs
+++ b/app/assets/javascripts/discourse/templates/components/expand-post.hbs
@@ -1,10 +1,10 @@
{{#if item.truncated}}
{{#if expanded}}
-
+
{{d-icon "chevron-up"}}
{{else}}
-
+
{{d-icon "chevron-down"}}
{{/if}}
diff --git a/app/assets/javascripts/discourse/templates/components/group-manage-logs-row.hbs b/app/assets/javascripts/discourse/templates/components/group-manage-logs-row.hbs
index d7754b460c8..dd929c5617d 100644
--- a/app/assets/javascripts/discourse/templates/components/group-manage-logs-row.hbs
+++ b/app/assets/javascripts/discourse/templates/components/group-manage-logs-row.hbs
@@ -33,13 +33,12 @@
{{bound-date log.created_at}} |
-
+ |
{{#if log.prev_value}}
- {{#if expandDetails}}
- {{d-icon 'ellipsis-v'}}
- {{else}}
- {{d-icon 'ellipsis-h'}}
- {{/if}}
+ {{d-button
+ action=(action "toggleDetails")
+ icon=(if expandDetails "angle-up" "angle-down")
+ }}
{{/if}}
|
diff --git a/app/assets/javascripts/discourse/templates/components/group-member.hbs b/app/assets/javascripts/discourse/templates/components/group-member.hbs
index ddc6456b833..dcdfc050d6f 100644
--- a/app/assets/javascripts/discourse/templates/components/group-member.hbs
+++ b/app/assets/javascripts/discourse/templates/components/group-member.hbs
@@ -1 +1,9 @@
-{{avatar member imageSize="small"}} {{member.username}} {{#unless automatic}}{{d-icon "times"}}{{/unless}}
+
+ {{avatar member imageSize="small"}}
+
+{{member.username}}
+{{#unless automatic}}
+
+ {{d-icon "times"}}
+
+{{/unless}}
diff --git a/app/assets/javascripts/discourse/templates/components/ip-lookup.hbs b/app/assets/javascripts/discourse/templates/components/ip-lookup.hbs
index 73c0ab7851f..9c9c2d39509 100644
--- a/app/assets/javascripts/discourse/templates/components/ip-lookup.hbs
+++ b/app/assets/javascripts/discourse/templates/components/ip-lookup.hbs
@@ -7,7 +7,7 @@
{{/if}}
{{#if show}}
-
{{d-icon "times"}}
+
{{d-icon "times"}}
{{#if copied}}
{{d-button class="btn-hover pull-right" icon="copy" label="ip_lookup.copied"}}
{{else}}
diff --git a/app/assets/javascripts/discourse/templates/components/reviewable-flagged-post.hbs b/app/assets/javascripts/discourse/templates/components/reviewable-flagged-post.hbs
index e6bb87508a9..09e196766fb 100644
--- a/app/assets/javascripts/discourse/templates/components/reviewable-flagged-post.hbs
+++ b/app/assets/javascripts/discourse/templates/components/reviewable-flagged-post.hbs
@@ -1,7 +1,7 @@
diff --git a/app/assets/javascripts/discourse/templates/components/signup-cta.hbs b/app/assets/javascripts/discourse/templates/components/signup-cta.hbs
index 1498e7b0053..f6587b40439 100644
--- a/app/assets/javascripts/discourse/templates/components/signup-cta.hbs
+++ b/app/assets/javascripts/discourse/templates/components/signup-cta.hbs
@@ -10,7 +10,7 @@
{{/if}}
diff --git a/app/assets/javascripts/discourse/templates/components/tag-info.hbs b/app/assets/javascripts/discourse/templates/components/tag-info.hbs
index feabad1cbc6..3b616fec811 100644
--- a/app/assets/javascripts/discourse/templates/components/tag-info.hbs
+++ b/app/assets/javascripts/discourse/templates/components/tag-info.hbs
@@ -38,10 +38,10 @@
{{discourse-tag tag.id pmOnly=tag.pmOnly tagName="div"}}
{{#if editSynonymsMode}}
-
+
{{d-icon "unlink" title="tagging.remove_synonym"}}
-
+
{{d-icon "far-trash-alt" title="tagging.delete_tag"}}
{{/if}}
diff --git a/app/assets/javascripts/discourse/templates/composer.hbs b/app/assets/javascripts/discourse/templates/composer.hbs
index 0f11a312cd3..ffc9fb49a41 100644
--- a/app/assets/javascripts/discourse/templates/composer.hbs
+++ b/app/assets/javascripts/discourse/templates/composer.hbs
@@ -196,7 +196,7 @@
{{/if}}
-
+
{{d-icon "desktop"}}
diff --git a/app/assets/javascripts/discourse/templates/discovery/topics.hbs b/app/assets/javascripts/discourse/templates/discovery/topics.hbs
index e7b2d385ada..5413f9d9bfc 100644
--- a/app/assets/javascripts/discourse/templates/discovery/topics.hbs
+++ b/app/assets/javascripts/discourse/templates/discovery/topics.hbs
@@ -44,11 +44,9 @@
{{else}}
{{#if topicTrackingState.hasIncoming}}
{{/if}}
{{/if}}
diff --git a/app/assets/javascripts/discourse/templates/full-page-search.hbs b/app/assets/javascripts/discourse/templates/full-page-search.hbs
index 56082d42ce9..1317bbc7532 100644
--- a/app/assets/javascripts/discourse/templates/full-page-search.hbs
+++ b/app/assets/javascripts/discourse/templates/full-page-search.hbs
@@ -41,8 +41,8 @@
{{#if bulkSelectEnabled}}
{{/if}}
diff --git a/app/assets/javascripts/discourse/templates/mobile/components/basic-topic-list.hbs b/app/assets/javascripts/discourse/templates/mobile/components/basic-topic-list.hbs
index a344ce85975..7c68ac0d05f 100644
--- a/app/assets/javascripts/discourse/templates/mobile/components/basic-topic-list.hbs
+++ b/app/assets/javascripts/discourse/templates/mobile/components/basic-topic-list.hbs
@@ -1,9 +1,9 @@
{{#conditional-loading-spinner condition=loading}}
{{#if hasIncoming}}
{{/if}}
@@ -17,7 +17,7 @@
{{topic-status topic=t}}
{{topic-link t}}
{{raw "list/unread-indicator" includeUnreadIndicator=showUnreadIndicator
- topicId=t.id
+ topicId=t.id
unreadClass=(if t.unread_by_group_member "" "read")}}
{{#if t.unseen}}
diff --git a/app/assets/javascripts/discourse/templates/mobile/components/mobile-nav.hbs b/app/assets/javascripts/discourse/templates/mobile/components/mobile-nav.hbs
index 83bdf44a111..bebe6a385e4 100644
--- a/app/assets/javascripts/discourse/templates/mobile/components/mobile-nav.hbs
+++ b/app/assets/javascripts/discourse/templates/mobile/components/mobile-nav.hbs
@@ -1,7 +1,10 @@
{{#if selectedHtml}}
-
- {{{selectedHtml}}}
+
-
+
+ {{{selectedHtml}}}
{{d-icon "caret-down"}}
-
+
+
{{/if}}
{{yield}}
diff --git a/app/assets/javascripts/discourse/templates/mobile/components/navigation-bar.hbs b/app/assets/javascripts/discourse/templates/mobile/components/navigation-bar.hbs
index 9d1ffb0932a..d760be82d27 100644
--- a/app/assets/javascripts/discourse/templates/mobile/components/navigation-bar.hbs
+++ b/app/assets/javascripts/discourse/templates/mobile/components/navigation-bar.hbs
@@ -1,5 +1,5 @@
-
-
+
{{selectedNavItem.displayName}}
{{d-icon "caret-down"}}
diff --git a/app/assets/javascripts/discourse/templates/mobile/discovery/topics.hbs b/app/assets/javascripts/discourse/templates/mobile/discovery/topics.hbs
index ff07193e109..01527f451b6 100644
--- a/app/assets/javascripts/discourse/templates/mobile/discovery/topics.hbs
+++ b/app/assets/javascripts/discourse/templates/mobile/discovery/topics.hbs
@@ -5,9 +5,9 @@
{{else}}
{{#if topicTrackingState.hasIncoming}}
-
+
{{/if}}
{{/if}}
diff --git a/app/assets/javascripts/discourse/templates/mobile/modal/login.hbs b/app/assets/javascripts/discourse/templates/mobile/modal/login.hbs
index 679308b4ac7..862a2fdd798 100644
--- a/app/assets/javascripts/discourse/templates/mobile/modal/login.hbs
+++ b/app/assets/javascripts/discourse/templates/mobile/modal/login.hbs
@@ -32,7 +32,7 @@
|
- {{i18n 'forgot_password.action'}}
+ {{i18n 'forgot_password.action'}}
|
diff --git a/app/assets/javascripts/discourse/templates/modal/auth-token.hbs b/app/assets/javascripts/discourse/templates/modal/auth-token.hbs
index 665a4e7e26c..1b08a4974bc 100644
--- a/app/assets/javascripts/discourse/templates/modal/auth-token.hbs
+++ b/app/assets/javascripts/discourse/templates/modal/auth-token.hbs
@@ -17,7 +17,7 @@
{{#if expanded}}
diff --git a/app/assets/javascripts/discourse/templates/modal/avatar-selector.hbs b/app/assets/javascripts/discourse/templates/modal/avatar-selector.hbs
index 59bb27619e4..cdaab1cc1c1 100644
--- a/app/assets/javascripts/discourse/templates/modal/avatar-selector.hbs
+++ b/app/assets/javascripts/discourse/templates/modal/avatar-selector.hbs
@@ -2,9 +2,9 @@
{{#if siteSettings.selectable_avatars_enabled}}
{{#each selectableAvatars as |avatar|}}
-
+
{{/each}}
{{else}}
diff --git a/app/assets/javascripts/discourse/templates/modal/group-bulk-add.hbs b/app/assets/javascripts/discourse/templates/modal/group-bulk-add.hbs
index 26b0b94188f..495c4a16c01 100644
--- a/app/assets/javascripts/discourse/templates/modal/group-bulk-add.hbs
+++ b/app/assets/javascripts/discourse/templates/modal/group-bulk-add.hbs
@@ -14,7 +14,7 @@
{{/if}}
{{else}}