github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-05-28 13:51:18 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

PERF: cook message in background (#24227)

Browse Source 
This commit starts from a simple observation: cooking messages on the hot path can be slow. Especially with a lot of mentions.

To move cooking from the hot path, this commit has made the following changes:

- updating cooked, inserting mentions and notifying user of new mentions has been moved inside the `process_message` job. It happens right after the `Chat::MessageProcessor` run, which is where the cooking happens.
- the similar existing code in `rebake!` has also been moved to rely on the `process_message`job only
- refactored `create_mentions` and `update_mentions` into one single `upsert_mentions` which can be called invariably
- allows services to decide if their job is ran inline or later. It avoids to need to know you have to use `Jobs.run_immediately!` in this case, in tests it will be inline per default
- made various frontend changes to make the chat-channel component lifecycle clearer. we had to handle `did-update @channel` which was super awkward and creating bugs with listeners which the changes of the PR made clear in failing specs
- adds a new `-processed` (and `-not-processed`) class on the chat message, this is made to have a good lifecyle hook in system specs
This commit is contained in:
Joffrey JAFFEUX
2023-11-06 15:45:30 +01:00
committed by GitHub
parent 4425e99bf9
commit 90efdd7f9d
46 changed files with 388 additions and 394 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
plugins/chat/spec/system/transcript_spec.rb
View File

@ -41,7 +41,7 @@ RSpec.describe "Quoting chat message transcripts", type: :system do
context "when quoting a single message into a topic" do
fab!(:post_1) { Fabricate(:post) }
fab!(:message_1) { Fabricate(:chat_message, chat_channel: chat_channel_1) }
fab!(:message_1) { Fabricate(:chat_message, chat_channel: chat_channel_1, use_service: true) }
it "quotes the message" do
chat_page.visit_channel(chat_channel_1)
@ -62,8 +62,8 @@ RSpec.describe "Quoting chat message transcripts", type: :system do
context "when quoting multiple messages into a topic" do
fab!(:post_1) { Fabricate(:post) }
fab!(:message_1) { Fabricate(:chat_message, chat_channel: chat_channel_1) }
fab!(:message_2) { Fabricate(:chat_message, chat_channel: chat_channel_1) }
fab!(:message_1) { Fabricate(:chat_message, chat_channel: chat_channel_1, use_service: true) }
fab!(:message_2) { Fabricate(:chat_message, chat_channel: chat_channel_1, use_service: true) }
it "quotes the messages" do
chat_page.visit_channel(chat_channel_1)
@ -85,7 +85,7 @@ RSpec.describe "Quoting chat message transcripts", type: :system do
context "when quoting a message containing a onebox" do
fab!(:post_1) { Fabricate(:post) }
fab!(:message_1) { Fabricate(:chat_message, chat_channel: chat_channel_1) }
fab!(:message_1) { Fabricate(:chat_message, chat_channel: chat_channel_1, use_service: true) }
before do
Oneboxer.stubs(:preview).returns(
@ -109,7 +109,7 @@ RSpec.describe "Quoting chat message transcripts", type: :system do
end
context "when quoting a message in another message" do
fab!(:message_1) { Fabricate(:chat_message, chat_channel: chat_channel_1) }
fab!(:message_1) { Fabricate(:chat_message, chat_channel: chat_channel_1, use_service: true) }
it "quotes the message" do
chat_page.visit_channel(chat_channel_1)
@ -125,7 +125,7 @@ RSpec.describe "Quoting chat message transcripts", type: :system do
end
context "when quoting into a topic directly" do
fab!(:message_1) { Fabricate(:chat_message, chat_channel: chat_channel_1) }
fab!(:message_1) { Fabricate(:chat_message, chat_channel: chat_channel_1, use_service: true) }
let(:topic_title) { "Some topic title for testing" }
it "opens the topic composer with correct state" do