github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-05-23 14:01:14 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

DEV: Don’t use change { … }.by(0) in specs

Browse Source
This commit is contained in:
Loïc Guitaut
2022-07-19 16:03:03 +02:00
committed by Loïc Guitaut
parent 3bfc254c4e
commit 91b6b5eee7
44 changed files with 138 additions and 136 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
spec/lib/auth/managed_authenticator_spec.rb
View File

@ -182,7 +182,7 @@ describe Auth::ManagedAuthenticator do
it "schedules the job upon update correctly" do
# No image supplied, do not schedule
expect { result = authenticator.after_authenticate(hash) }
.to change { Jobs::DownloadAvatarFromUrl.jobs.count }.by(0)
.not_to change { Jobs::DownloadAvatarFromUrl.jobs.count }
# Image supplied, schedule
expect { result = authenticator.after_authenticate(hash.deep_merge(info: { image: "https://some.domain/image.jpg" })) }
@ -192,7 +192,7 @@ describe Auth::ManagedAuthenticator do
user.user_avatar = Fabricate(:user_avatar, custom_upload: Fabricate(:upload))
user.save!
expect { result = authenticator.after_authenticate(hash.deep_merge(info: { image: "https://some.domain/image.jpg" })) }
.to change { Jobs::DownloadAvatarFromUrl.jobs.count }.by(0)
.not_to change { Jobs::DownloadAvatarFromUrl.jobs.count }
end
end
@ -226,7 +226,7 @@ describe Auth::ManagedAuthenticator do
it "doesn't schedule with no image" do
expect { result = authenticator.after_create_account(user, create_auth_result(extra_data: create_hash)) }
.to change { Jobs::DownloadAvatarFromUrl.jobs.count }.by(0)
.not_to change { Jobs::DownloadAvatarFromUrl.jobs.count }
end
it "schedules with image" do