github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-06-04 10:24:39 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

DEV: Don’t use change { … }.by(0) in specs

Browse Source
This commit is contained in:
Loïc Guitaut
2022-07-19 16:03:03 +02:00
committed by Loïc Guitaut
parent 3bfc254c4e
commit 91b6b5eee7
44 changed files with 138 additions and 136 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
spec/lib/post_revisor_spec.rb
View File

@ -148,7 +148,7 @@ describe PostRevisor do
SiteSetting.disable_tags_edit_notifications = true
expect { subject.revise!(admin, tags: ['new-tag']) }
.to change { Notification.count }.by(0)
.not_to change { Notification.count }
end
end
@ -1278,8 +1278,8 @@ describe PostRevisor do
{ title: "updated title for my topic" },
keep_existing_draft: true
)
}.to change { Draft.where(user: user, draft_key: draft_key).first.sequence }.by(0)
.and change { DraftSequence.where(user_id: user.id, draft_key: draft_key).first.sequence }.by(0)
}.to not_change { Draft.where(user: user, draft_key: draft_key).first.sequence }
.and not_change { DraftSequence.where(user_id: user.id, draft_key: draft_key).first.sequence }
expect {
PostRevisor.new(post).revise!(
@ -1307,7 +1307,7 @@ describe PostRevisor do
it 'does nothing when a staff member edits a post' do
admin = Fabricate(:admin)
expect { revisor.revise!(admin, { raw: 'updated body' }) }.to change(ReviewablePost, :count).by(0)
expect { revisor.revise!(admin, { raw: 'updated body' }) }.not_to change(ReviewablePost, :count)
end
it 'skips grace period edits' do
@ -1315,7 +1315,7 @@ describe PostRevisor do
expect {
revisor.revise!(post.user, { raw: 'updated body' }, revised_at: post.updated_at + 10.seconds)
}.to change(ReviewablePost, :count).by(0)
}.not_to change(ReviewablePost, :count)
end
end
end