github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-06-04 10:17:19 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

DEV: Don’t use change { … }.by(0) in specs

Browse Source
This commit is contained in:
Loïc Guitaut
2022-07-19 16:03:03 +02:00
committed by Loïc Guitaut
parent 3bfc254c4e
commit 91b6b5eee7
44 changed files with 138 additions and 136 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
spec/lib/seed_data/categories_spec.rb
View File

@ -42,8 +42,8 @@ describe SeedData::Categories do
it "does not create another category" do
expect { create_category }
.to change { Category.count }.by(0)
.and change { Topic.count }.by(0)
.to not_change { Category.count }
.and not_change { Topic.count }
end
it "creates a missing 'About Category' topic" do
@ -51,7 +51,7 @@ describe SeedData::Categories do
Topic.delete(category.topic_id)
expect { create_category }
.to change { Category.count }.by(0)
.to not_change { Category.count }
.and change { Topic.count }.by(1)
category.reload
@ -103,7 +103,7 @@ describe SeedData::Categories do
expect(category.category_groups.first).to have_attributes(permissions(:trust_level_2, :full))
expect { create_category("lounge_category_id") }
.to change { CategoryGroup.count }.by(0)
.not_to change { CategoryGroup.count }
category.reload
expect(category.category_groups.first).to have_attributes(permissions(:trust_level_2, :full))