github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-06-03 14:04:36 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

DEV: Don’t use change { … }.by(0) in specs

Browse Source
This commit is contained in:
Loïc Guitaut
2022-07-19 16:03:03 +02:00
committed by Loïc Guitaut
parent 3bfc254c4e
commit 91b6b5eee7
44 changed files with 138 additions and 136 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
spec/requests/groups_controller_spec.rb
View File

@ -1352,7 +1352,7 @@ describe GroupsController do
it "does not notify users when the param is not present" do
expect {
put "/groups/#{group.id}/members.json", params: { usernames: user2.username }
}.to change { Topic.where(archetype: "private_message").count }.by(0)
}.not_to change { Topic.where(archetype: "private_message").count }
expect(response.status).to eq(200)
end
@ -1453,7 +1453,7 @@ describe GroupsController do
expect do
put "/groups/#{group.id}/members.json",
params: { user_emails: [user1.email, user2.email, user3.email].join(",") }
end.to change { group.users.count }.by(0)
end.not_to change { group.users.count }
expect(response.status).to eq(422)
@ -1469,7 +1469,7 @@ describe GroupsController do
expect do
put "/groups/#{group.id}/members.json",
params: { user_emails: [user1.email, user2.email].join(",") }
end.to change { group.reload.users.count }.by(0)
end.not_to change { group.reload.users.count }
expect(response.status).to eq(422)