github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-05-23 20:56:54 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

DEV: correct intermittent test failure

Browse Source 
ActionController::BadRequest can not be re-dispatched, under some conditions
we are getting this vs InvalidParameterError in the following test

59c56bd20f/spec/requests/application_controller_spec.rb (L34-L62)
This commit is contained in:
Sam
2018-12-13 18:27:02 +11:00
parent 8ef2085585
commit 939b82ef0c
1 changed files with 3 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
lib/middleware/discourse_public_exceptions.rb
View File

@ -20,6 +20,9 @@ module Middleware
# the Request object has a "broken" .params which can not be accessed # the Request object has a "broken" .params which can not be accessed
exception = nil if Rack::QueryParser::InvalidParameterError === exception exception = nil if Rack::QueryParser::InvalidParameterError === exception
# We also can not dispatch bad requests as no proper params
exception = nil if ActionController::BadRequest === exception
if exception if exception
begin begin
fake_controller = ApplicationController.new fake_controller = ApplicationController.new