github-mirror/discourse
github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-04-25 22:24:32 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

FIX: dont error when bookmark topic is nil (#10555)

Browse Source
This commit is contained in:
Krzysztof Kotlarek 2020-08-31 09:15:36 +10:00 committed by GitHub
parent b31da92ede
commit 94152e4640
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 8 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
lib/bookmark_reminder_notification_handler.rb
View File

@ -7,6 +7,7 @@ class BookmarkReminderNotificationHandler
if bookmark.post.blank? || bookmark.post.deleted_at.present? if bookmark.post.blank? || bookmark.post.deleted_at.present?
return clear_reminder(bookmark) return clear_reminder(bookmark)
end end
return unless bookmark.topic
create_notification(bookmark) create_notification(bookmark)

7
spec/jobs/bookmark_reminder_notifications_spec.rb
View File

@ -59,4 +59,11 @@ RSpec.describe Jobs::BookmarkReminderNotifications do
end end
end end
end end
it 'will not send notification when topic is not available' do
bookmark1.topic.destroy
bookmark2.topic.destroy
bookmark3.topic.destroy
expect { subject.execute }.not_to change { Notification.where(notification_type: Notification.types[:bookmark_reminder]).count }
end
end end