github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-06-03 19:39:30 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

FIX: User can't reset password with backup codes when only security key is enabled (#27368)

Browse Source 
This commit fixes a problem where the user will not be able to reset
their password when they only have security keys and backup codes
configured.

This commit also makes the following changes/fixes:

1. Splits password reset system tests to
   `spec/system/forgot_password_spec.rb` instead of missing the system
   tests in `spec/system/login_spec.rb` which is mainly used to test
   the login flow.

2. Fixes a UX issue where the `Use backup codes` or `Use authenticator
   app` text is shown on the reset password form when the user does
   not have either backup codes or an authenticator app configured.
This commit is contained in:
Alan Guo Xiang Tan
2024-06-06 14:30:42 +08:00
committed by GitHub
parent 4b1e017722
commit 952f69ce60
16 changed files with 363 additions and 76 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
spec/requests/session_controller_spec.rb
View File

@ -99,6 +99,7 @@ RSpec.describe SessionController do
expect(response_body_parsed["can_login"]).to eq(true)
expect(response_body_parsed["second_factor_required"]).to eq(true)
expect(response_body_parsed["backup_codes_enabled"]).to eq(true)
expect(response_body_parsed["totp_enabled"]).to eq(true)
end
end