github-mirror/discourse
github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-04-19 06:49:04 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

FIX: do not mutate this.attrs and this.actions (#23125)

Browse Source 
Prior to this fix we would always re-set `this.attrs` with `this.attrs` when defined, which is both wasteful but also dangerous as `this.attrs` can possibly error when mutated.
This commit is contained in:
Joffrey JAFFEUX 2023-08-17 18:07:06 +02:00 committed by GitHub
parent 712bbf9b88
commit 95c4d97db3
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
app/assets/javascripts/select-kit/addon/components/select-kit.js
View File

@ -1127,8 +1127,8 @@ export default Component.extend(
},
_deprecateMutations() {
this.actions = this.actions || {};
this.attrs = this.attrs || {};
this.actions ??= {};
this.attrs ??= {};
if (!this.attrs.onChange && !this.actions.onChange) {
this._deprecated(