github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-05-28 13:51:18 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

DEV: removes _.each from codebase (#6629)

Browse Source
This commit is contained in:
Joffrey JAFFEUX
2018-11-20 14:46:58 +01:00
committed by GitHub
parent a2042c8e7d
commit 9672c92045
23 changed files with 77 additions and 81 deletions
Download Patch File Download Diff File Expand all files Collapse all files

30
test/javascripts/components/keyboard-shortcuts-test.js.es6
View File

@ -14,7 +14,7 @@ QUnit.module("lib:keyboard-shortcuts", {
}, this);
if (_.isArray(bindings)) {
_.each(bindings, registerBinding, this);
bindings.forEach(registerBinding, this);
} else {
registerBinding(bindings);
}
@ -67,9 +67,9 @@ QUnit.module("lib:keyboard-shortcuts", {
}
});
var pathBindings = KeyboardShortcuts.PATH_BINDINGS;
_.each(pathBindings, function(path, binding) {
var pathBindings = KeyboardShortcuts.PATH_BINDINGS || {};
Object.keys(pathBindings).forEach(path => {
const binding = pathBindings[path];
var testName = binding + " goes to " + path;
test(testName, function(assert) {
@ -80,9 +80,9 @@ _.each(pathBindings, function(path, binding) {
});
});
var clickBindings = KeyboardShortcuts.CLICK_BINDINGS;
_.each(clickBindings, function(selector, binding) {
var clickBindings = KeyboardShortcuts.CLICK_BINDINGS || {};
Object.keys(clickBindings).forEach(selector => {
const binding = clickBindings[selector];
var bindings = binding.split(",");
var testName = binding + " clicks on " + selector;
@ -93,19 +93,15 @@ _.each(clickBindings, function(selector, binding) {
assert.ok(true, selector + " was clicked");
});
_.each(
bindings,
function(b) {
testMouseTrap.trigger(b);
},
this
);
bindings.forEach(function(b) {
testMouseTrap.trigger(b);
}, this);
});
});
var functionBindings = KeyboardShortcuts.FUNCTION_BINDINGS;
_.each(functionBindings, function(func, binding) {
var functionBindings = KeyboardShortcuts.FUNCTION_BINDINGS || {};
Object.keys(functionBindings).forEach(func => {
const binding = functionBindings[func];
var testName = binding + " calls " + func;
test(testName, function(assert) {