DEV: Convert more notOk assertions (#29556)

…to either qunit-dom or `strictEqual`

plugins/chat/test/javascripts/unit/services/chat-emoji-picker-manager-test.js

@@ -102,8 +102,8 @@ module(
 
       await settled();
 
-      assert.notOk(this.manager.picker);
-      assert.notOk(this.manager.closing);
+      assert.strictEqual(this.manager.picker, null);
+      assert.false(this.manager.closing);
       assert.deepEqual(
         this.manager.visibleSections,
         ["favorites", "smileys_&_emotion"],

plugins/chat/test/javascripts/unit/services/chat-guardian-test.js

@@ -25,29 +25,29 @@ acceptance("Discourse Chat | Unit | Service | chat-guardian", function (needs) {
     set(this.currentUser, "admin", false);
     set(this.currentUser, "moderator", false);
     this.siteSettings.chat_enabled = false;
-    assert.notOk(this.chatGuardian.canEditChatChannel());
+    assert.false(this.chatGuardian.canEditChatChannel());
 
     set(this.currentUser, "has_chat_enabled", true);
     set(this.currentUser, "admin", true);
     this.siteSettings.chat_enabled = false;
-    assert.notOk(this.chatGuardian.canEditChatChannel());
+    assert.false(this.chatGuardian.canEditChatChannel());
 
     set(this.currentUser, "has_chat_enabled", false);
     set(this.currentUser, "admin", false);
     set(this.currentUser, "moderator", false);
     this.siteSettings.chat_enabled = true;
-    assert.notOk(this.chatGuardian.canEditChatChannel());
+    assert.false(this.chatGuardian.canEditChatChannel());
 
     set(this.currentUser, "has_chat_enabled", false);
     set(this.currentUser, "admin", true);
     this.siteSettings.chat_enabled = true;
-    assert.notOk(this.chatGuardian.canEditChatChannel());
+    assert.false(this.chatGuardian.canEditChatChannel());
 
     set(this.currentUser, "has_chat_enabled", true);
     set(this.currentUser, "admin", false);
     set(this.currentUser, "moderator", false);
     this.siteSettings.chat_enabled = true;
-    assert.notOk(this.chatGuardian.canEditChatChannel());
+    assert.false(this.chatGuardian.canEditChatChannel());
 
     set(this.currentUser, "has_chat_enabled", true);
     set(this.currentUser, "admin", true);
@@ -58,11 +58,11 @@ acceptance("Discourse Chat | Unit | Service | chat-guardian", function (needs) {
   test("#canUseChat", async function (assert) {
     set(this.currentUser, "has_chat_enabled", false);
     this.siteSettings.chat_enabled = true;
-    assert.notOk(this.chatGuardian.canUseChat());
+    assert.false(this.chatGuardian.canUseChat());
 
     set(this.currentUser, "has_chat_enabled", true);
     this.siteSettings.chat_enabled = false;
-    assert.notOk(this.chatGuardian.canUseChat());
+    assert.false(this.chatGuardian.canUseChat());
 
     set(this.currentUser, "has_chat_enabled", true);
     this.siteSettings.chat_enabled = true;
@@ -80,16 +80,16 @@ acceptance("Discourse Chat | Unit | Service | chat-guardian", function (needs) {
 
     set(this.currentUser, "admin", false);
     set(this.currentUser, "moderator", false);
-    assert.notOk(this.chatGuardian.canArchiveChannel(channel));
+    assert.false(this.chatGuardian.canArchiveChannel(channel));
     set(this.currentUser, "admin", true);
     set(this.currentUser, "moderator", true);
 
     channel.status = "read_only";
-    assert.notOk(this.chatGuardian.canArchiveChannel(channel));
+    assert.false(this.chatGuardian.canArchiveChannel(channel));
     channel.status = "open";
 
     channel.status = "archived";
-    assert.notOk(this.chatGuardian.canArchiveChannel(channel));
+    assert.false(this.chatGuardian.canArchiveChannel(channel));
     channel.status = "open";
   });
 });

plugins/chat/test/javascripts/unit/services/chat-state-manager-test.js

@@ -22,7 +22,7 @@ module(
     });
 
     test("isFullPagePreferred", function (assert) {
-      assert.notOk(this.subject.isFullPagePreferred);
+      assert.false(this.subject.isFullPagePreferred);
 
       this.subject.prefersFullPage();
 
@@ -30,7 +30,7 @@ module(
 
       this.subject.prefersDrawer();
 
-      assert.notOk(this.subject.isFullPagePreferred);
+      assert.false(this.subject.isFullPagePreferred);
 
       this.subject.prefersDrawer();
       Site.currentProp("mobileView", true);
@@ -43,7 +43,7 @@ module(
 
       this.subject.prefersFullPage();
 
-      assert.notOk(this.subject.isDrawerPreferred);
+      assert.false(this.subject.isDrawerPreferred);
 
       this.subject.prefersDrawer();
 
@@ -73,7 +73,7 @@ module(
 
     test("isFullPageActive", function (assert) {
       sinon.stub(this.subject.router, "currentRouteName").value("foo");
-      assert.notOk(this.subject.isFullPageActive);
+      assert.false(this.subject.isFullPageActive);
 
       sinon.stub(this.subject.router, "currentRouteName").value("chat");
       assert.ok(this.subject.isFullPageActive);

plugins/chat/test/javascripts/unit/utility/plugin-api-test.js

@@ -68,7 +68,7 @@ module("Chat | Unit | Utility | plugin-api", function (hooks) {
           updatedSecondaryActions.length < secondaryActions.length,
           "the updated secondary actions must contain less items than the original"
         );
-        assert.notOk(
+        assert.false(
           updatedSecondaryActions
             .map((v) => v.id)
             .includes(secondaryActions[0]),