Remove legacy vote post action code. (#6009)

lib/migration/base_dropper.rb

@@ -1,8 +1,9 @@
 module Migration
   class BaseDropper
-    def initialize(after_migration, delay, on_drop)
+    def initialize(after_migration, delay, on_drop, after_drop)
       @after_migration = after_migration
       @on_drop = on_drop
+      @after_drop = after_drop
 
       # in production we need some extra delay to allow for slow migrations
       @delay = delay || (Rails.env.production? ? 3600 : 0)
@@ -12,6 +13,7 @@ module Migration
       if droppable?
         @on_drop&.call
         execute_drop!
+        @after_drop&.call
 
         Discourse.reset_active_record_cache
       end

lib/migration/column_dropper.rb

@@ -2,11 +2,13 @@ require_dependency 'migration/base_dropper'
 
 module Migration
   class ColumnDropper < BaseDropper
-    def self.drop(table:, after_migration:, columns:, delay: nil, on_drop: nil)
+    def self.drop(table:, after_migration:, columns:, delay: nil, on_drop: nil, after_drop: nil)
       validate_table_name(table)
       columns.each { |column| validate_column_name(column) }
 
-      ColumnDropper.new(table, columns, after_migration, delay, on_drop).delayed_drop
+      ColumnDropper.new(
+        table, columns, after_migration, delay, on_drop, after_drop
+      ).delayed_drop
     end
 
     def self.mark_readonly(table_name, column_name)
@@ -24,8 +26,8 @@ module Migration
 
     private
 
-    def initialize(table, columns, after_migration, delay, on_drop)
-      super(after_migration, delay, on_drop)
+    def initialize(table, columns, after_migration, delay, on_drop, after_drop)
+      super(after_migration, delay, on_drop, after_drop)
 
       @table = table
       @columns = columns

lib/migration/table_dropper.rb

@@ -2,17 +2,21 @@ require_dependency 'migration/base_dropper'
 
 module Migration
   class Migration::TableDropper < BaseDropper
-    def self.delayed_drop(table_name:, after_migration:, delay: nil, on_drop: nil)
+    def self.delayed_drop(table_name:, after_migration:, delay: nil, on_drop: nil, after_drop: nil)
       validate_table_name(table_name)
 
-      TableDropper.new(table_name, nil, after_migration, delay, on_drop).delayed_drop
+      TableDropper.new(
+        table_name, nil, after_migration, delay, on_drop, after_drop
+      ).delayed_drop
     end
 
-    def self.delayed_rename(old_name:, new_name:, after_migration:, delay: nil, on_drop: nil)
+    def self.delayed_rename(old_name:, new_name:, after_migration:, delay: nil, on_drop: nil, after_drop: nil)
       validate_table_name(old_name)
       validate_table_name(new_name)
 
-      TableDropper.new(old_name, new_name, after_migration, delay, on_drop).delayed_drop
+      TableDropper.new(
+        old_name, new_name, after_migration, delay, on_drop, after_drop
+      ).delayed_drop
     end
 
     def self.read_only_table(table_name)
@@ -29,8 +33,8 @@ module Migration
 
     private
 
-    def initialize(old_name, new_name, after_migration, delay, on_drop)
-      super(after_migration, delay, on_drop)
+    def initialize(old_name, new_name, after_migration, delay, on_drop, after_drop)
+      super(after_migration, delay, on_drop, after_drop)
 
       @old_name = old_name
       @new_name = new_name