Enums that are used in tables need to be stable

spec/components/enum_spec.rb

@@ -2,37 +2,51 @@ require 'rails_helper'
 require 'email'
 
 describe Enum do
-  let(:enum) { Enum.new(:jake, :finn, :princess_bubblegum, :peppermint_butler) }
+  let(:array_enum) { Enum.new(:jake, :finn, :princess_bubblegum, :peppermint_butler) }
+  let(:hash_enum) { Enum.new(jake: 1, finn: 2, princess_bubblegum: 3, peppermint_butler: 4) }
 
   describe ".[]" do
     it "looks up a number by symbol" do
-      expect(enum[:princess_bubblegum]).to eq(3)
+      expect(array_enum[:princess_bubblegum]).to eq(3)
+      expect(hash_enum[:princess_bubblegum]).to eq(3)
     end
 
     it "looks up a symbol by number" do
-      expect(enum[2]).to eq(:finn)
+      expect(array_enum[2]).to eq(:finn)
+      expect(hash_enum[2]).to eq(:finn)
     end
   end
 
   describe ".valid?" do
     it "returns true if a key exists" do
-      expect(enum.valid?(:finn)).to eq(true)
+      expect(array_enum.valid?(:finn)).to eq(true)
+      expect(hash_enum.valid?(:finn)).to eq(true)
     end
 
     it "returns false if a key does not exist" do
-      expect(enum.valid?(:obama)).to eq(false)
+      expect(array_enum.valid?(:obama)).to eq(false)
+      expect(hash_enum.valid?(:obama)).to eq(false)
     end
   end
 
   describe ".only" do
     it "returns only the values we ask for" do
-      expect(enum.only(:jake, :princess_bubblegum)).to eq({ jake: 1, princess_bubblegum: 3 })
+      expect(array_enum.only(:jake, :princess_bubblegum)).to eq({ jake: 1, princess_bubblegum: 3 })
+      expect(hash_enum.only(:jake, :princess_bubblegum)).to eq({ jake: 1, princess_bubblegum: 3 })
     end
   end
 
   describe ".except" do
     it "returns everything but the values we ask to delete" do
-      expect(enum.except(:jake, :princess_bubblegum)).to eq({ finn: 2, peppermint_butler: 4 })
+      expect(array_enum.except(:jake, :princess_bubblegum)).to eq({ finn: 2, peppermint_butler: 4 })
+      expect(hash_enum.except(:jake, :princess_bubblegum)).to eq({ finn: 2, peppermint_butler: 4 })
+    end
+  end
+
+  context "allows to specify number of first enum member" do
+    it "number of first enum member should be 0 " do
+      start_enum = Enum.new(:jake, :finn, :princess_bubblegum, :peppermint_butler, start: 0)
+      expect(start_enum[:princess_bubblegum]).to eq(2)
     end
   end
 end

spec/components/site_setting_extension_spec.rb

@@ -3,6 +3,23 @@ require_dependency 'site_setting_extension'
 require_dependency 'site_settings/local_process_provider'
 
 describe SiteSettingExtension do
+
+  describe '#types' do
+    context "verify enum sequence" do
+      before do
+        @types = SiteSetting.types
+      end
+
+      it "'string' should be at 1st position" do
+        expect(@types[:string]).to eq(1)
+      end
+
+      it "'value_list' should be at 12th position" do
+        expect(@types[:value_list]).to eq(12)
+      end
+    end
+  end
+  
   let :provider_local do
     SiteSettings::LocalProcessProvider.new
   end

spec/components/trust_level_spec.rb

@@ -0,0 +1,19 @@
+require 'rails_helper'
+
+describe TrustLevel do
+  describe 'levels' do
+    context "verify enum sequence" do
+      before do
+        @levels = TrustLevel.levels
+      end
+
+      it "'newuser' should be at 0 position" do
+        expect(@levels[:newuser]).to eq(0)
+      end
+
+      it "'leader' should be at 4th position" do
+        expect(@levels[:leader]).to eq(4)
+      end
+    end
+  end
+end