github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-06-06 21:34:52 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

DEV: Fix setting-on-hash deprecation (#23506)

Browse Source 
```
deprecate-shim.js:33 DEPRECATION: You set the 'hasSavedVote' property on a {{hash}} object. Setting properties on objects generated by {{hash}} is deprecated. Please update to use an object created with a tracked property or getter, or with a custom helper. [deprecation id: setting-on-hash]
```
This commit is contained in:
Jarek Radosz
2023-09-11 16:15:44 +02:00
committed by GitHub
parent f27800ff88
commit 992737e592
1 changed files with 86 additions and 84 deletions
Download Patch File Download Diff File Expand all files Collapse all files

46
plugins/poll/test/javascripts/widgets/discourse-poll-test.js
View File

@ -46,21 +46,10 @@ module("Integration | Component | Widget | discourse-poll", function (hooks) {
}); });
}); });
const template = hbs`
<MountWidget
@widget="discourse-poll"
@args={{hash
id=this.id
post=this.post
poll=this.poll
vote=this.vote
groupableUserFields=this.groupableUserFields
}}
/>
`;
test("can vote", async function (assert) { test("can vote", async function (assert) {
this.setProperties({ this.set(
"args",
EmberObject.create({
post: EmberObject.create({ post: EmberObject.create({
id: 42, id: 42,
topic: { topic: {
@ -81,9 +70,12 @@ module("Integration | Component | Widget | discourse-poll", function (hooks) {
}), }),
vote: [], vote: [],
groupableUserFields: [], groupableUserFields: [],
}); })
);
await render(template); await render(
hbs`<MountWidget @widget="discourse-poll" @args={{this.args}} />`
);
requests = 0; requests = 0;
@ -103,7 +95,9 @@ module("Integration | Component | Widget | discourse-poll", function (hooks) {
}); });
test("cannot vote if not member of the right group", async function (assert) { test("cannot vote if not member of the right group", async function (assert) {
this.setProperties({ this.set(
"args",
EmberObject.create({
post: EmberObject.create({ post: EmberObject.create({
id: 42, id: 42,
topic: { topic: {
@ -125,9 +119,12 @@ module("Integration | Component | Widget | discourse-poll", function (hooks) {
}), }),
vote: [], vote: [],
groupableUserFields: [], groupableUserFields: [],
}); })
);
await render(template); await render(
hbs`<MountWidget @widget="discourse-poll" @args={{this.args}} />`
);
requests = 0; requests = 0;
@ -141,7 +138,9 @@ module("Integration | Component | Widget | discourse-poll", function (hooks) {
}); });
test("voting on a multiple poll with no min attribute", async function (assert) { test("voting on a multiple poll with no min attribute", async function (assert) {
this.setProperties({ this.set(
"args",
EmberObject.create({
post: EmberObject.create({ post: EmberObject.create({
id: 42, id: 42,
topic: { topic: {
@ -163,9 +162,12 @@ module("Integration | Component | Widget | discourse-poll", function (hooks) {
}), }),
vote: [], vote: [],
groupableUserFields: [], groupableUserFields: [],
}); })
);
await render(template); await render(
hbs`<MountWidget @widget="discourse-poll" @args={{this.args}} />`
);
assert.ok(exists(".poll-buttons .cast-votes[disabled=true]")); assert.ok(exists(".poll-buttons .cast-votes[disabled=true]"));
await click("li[data-poll-option-id='1f972d1df351de3ce35a787c89faad29']"); await click("li[data-poll-option-id='1f972d1df351de3ce35a787c89faad29']");