github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-05-28 22:47:46 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

DEV: Handle CORS and other fetch failures for media-optimization-worker (#15364)

Browse Source 
Occasionally there will be a misconfigured CORS rule or a different
network failure when loading one of the media optimization WASM scripts.
This commit handles load failures and sends a new installFailed message
from the service worker, so that we don't error and hold up the rest
of the uploads if this occurs; the worker will just not process anything
and will keep trying to install itself with subsequent uploads until it succeeds.

This commit also removes the redundant useUppy variable in the worker
this should have been removed a while ago in f70e6c302fddd38595a1fc90e24964a2cb0716bb
This commit is contained in:
Martin Brennan
2021-12-21 09:00:19 +10:00
committed by GitHub
parent 07436e9d8c
commit 995c514336
2 changed files with 28 additions and 30 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
public/javascripts/media-optimization-worker.js
View File

@ -148,8 +148,12 @@ onmessage = async function (e) {
}
break;
case "install":
await loadLibs(e.data.settings);
postMessage({ type: "installed" });
try {
await loadLibs(e.data.settings);
postMessage({ type: "installed" });
} catch (error) {
postMessage({ type: "installFailed", errorMessage: error.message });
}
break;
default:
logIfDebug(`Sorry, we are out of ${e}.`);